Date: Mon, 15 Mar 2010 07:28:07 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: freebsd-current@FreeBSD.org Subject: Re: [PATCH] newvers.sh Message-ID: <20100315142806.GA5786@dragon.NUXI.org> In-Reply-To: <20100313.211303.585238797224891349.imp@bsdimp.com> References: <20100312171206.GA31761@dragon.NUXI.org> <20100313.211303.585238797224891349.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: > In message: <20100312171206.GA31761@dragon.NUXI.org> > "David O'Brien" <obrien@freebsd.org> writes: > : * Simplify SRCDIR calculation by directly finding the kernel sources > : based directly on one of them. > : Reviewed by: dhw > : This change does not increase the kernel build time. It also continues > : to restrict the revision to just the kernel sources, and not the whole > : tree. > : Timing tests by: dhw > > <patch omitted> > > I have a better simplification, I think, that works for me for each of > the tests that I've done (both traditional and buildkernel builds). I also have other simplifications. But want to do this in stages, least there be some corner case or misunderstanding by someone. > Can you confirm this works for you and also comment on the change > itself? It is a bigger change, but results in a simpler (I think) > newvers.sh. > Comments? I would prefer to do this in stages so things aren't misunderstood. This patch is one of the key parts that shows I am not making the 'svnversion' run take longer, and that it does not cover more of the tree than before. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100315142806.GA5786>