Date: Sun, 14 Sep 2008 21:12:07 -0700 From: "Garrett Cooper" <yanefbsd@gmail.com> To: "FreeBSD Ports" <freebsd-ports@freebsd.org>, current@freebsd.org Subject: Fwd: bin/125932: pkg_add(1) doesn't prompt for root credentials and then fails badly Message-ID: <7d6fde3d0809142112o4de36352md0302b4d8608b03f@mail.gmail.com> In-Reply-To: <7d6fde3d0809142110x1d28e40fm4e976f93ae507852@mail.gmail.com> References: <200807241348.m6ODmVNe090621@www.freebsd.org> <7d6fde3d0807241118x122c25dbjad0e6f7b98f789d7@mail.gmail.com> <20080909212343.58886989@tau.draftnet> <7d6fde3d0809112324l5d99c157n1d5f23efbb32f3bf@mail.gmail.com> <7d6fde3d0809142110x1d28e40fm4e976f93ae507852@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------------------------ Fyi (From Bugbuster email for bin/125932): ------------------------ Here's a proposed patch for the first set of cleanup to pkg_install: <http://pastebin.com/f1cee71c2>, and some fixing to alleviate the issue in bin/125932. Rather than biting off more than I can chew with the perforce project, I'm going to work off the changes Anders has made and incrementally polish pkg_install (like I should have done last year -_-...) This patch causes pkg_install to error out at the first sign of install failure (which could take a while as it's still using tar(1) to extract archives in add/extract.c), BUT in getFileByURL I've completely replaced the tar requirement in lib/url.c with archive(3)'s, quite handy hooks for writing to files. So don't be alarmed when you see that the file has grown 4 times ;)... This patch hasn't gotten much mileage, other than a few failure and success cases, so if others could please take a look at this and provide comments I'd much appreciate it. Cheers, -Garrett PS Packages might not be dumped in the correct spot -- I just chose /var/tmp, but if someone could point me to the "industry standard" location that portupgrade uses for instance, I'd be more than happy to point there.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d0809142112o4de36352md0302b4d8608b03f>