Date: Wed, 21 Feb 2024 18:39:05 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 4dc04ac964f8 - main - net/libngtcp2: Update to 1.3.0 Message-ID: <fada341992606fed9aa13f4a9460b58f@mail.infomaniak.com> In-Reply-To: <202402211519.41LFJOKo017162@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-02-21T16:19:24.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote: > The branch main has been updated by sunpoet: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=4dc04ac964f8af7666478eff399814f102fb5eb1 > > commit 4dc04ac964f8af7666478eff399814f102fb5eb1 > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2024-02-21 14:27:22 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2024-02-21 15:06:37 +0000 > > net/libngtcp2: Update to 1.3.0 > > > > - Convert back to autotools > > - Remove unnecessary substitution > > > > Changes: https://github.com/ngtcp2/ngtcp2/releases > > --- > > net/libngtcp2/Makefile | 17 ++++++++--------- > > net/libngtcp2/distinfo | 6 +++--- > > net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in] | 13 +++++++++++++ > > net/libngtcp2/pkg-plist | 2 +- > > 4 files changed, 25 insertions(+), 13 deletions(-) > > diff --git a/net/libngtcp2/Makefile b/net/libngtcp2/Makefile > > index 1deb680168a1..215e17283363 100644 > > --- a/net/libngtcp2/Makefile > > +++ b/net/libngtcp2/Makefile > > @@ -1,7 +1,7 @@ > > PORTNAME= ngtcp2 > > -DISTVERSION= 1.2.0 > > +PORTVERSION= 1.3.0 > > CATEGORIES= net > > -MASTER_SITES= https://github.com/${PORTNAME}/${PORTNAME}/releases/download/v${DISTVERSION}/ > > +MASTER_SITES= https://github.com/ngtcp2/ngtcp2/releases/download/v${PORTVERSION}/ > > PKGNAMEPREFIX= lib > > > > MAINTAINER= sunpoet@FreeBSD.org > > @@ -12,13 +12,12 @@ WWW= https://nghttp2.org/ngtcp2/ \ > > LICENSE= MIT > > LICENSE_FILE= ${WRKSRC}/COPYING > > > > -USES= cmake compiler:c++14-lang pathfix tar:xz > > -USE_LDCONFIG= yes > > +USES= compiler:c++14-lang libtool pathfix pkgconfig tar:xz > > > > -# Always disabled due to lack of QUIC support which is in 3.2 > > -CMAKE_OFF= ENABLE_OPENSSL > > -CMAKE_ON= CMAKE_DISABLE_FIND_PACKAGE_CUnit \ > > - CMAKE_DISABLE_FIND_PACKAGE_Libev \ > > - CMAKE_DISABLE_FIND_PACKAGE_Libnghttp3 > > +CONFIGURE_ARGS= --enable-lib-only --with-jemalloc > > +GNU_CONFIGURE= yes > > +INSTALL_TARGET= install-strip > > +USE_CXXSTD= c++14 > > +USE_LDCONFIG= yes > > > > .include <bsd.port.mk> [http://bsd.port.mk>]; > > diff --git a/net/libngtcp2/distinfo b/net/libngtcp2/distinfo > > index 5e02e151e88b..5b049b4b98d5 100644 > > --- a/net/libngtcp2/distinfo > > +++ b/net/libngtcp2/distinfo > > @@ -1,3 +1,3 @@ > > -TIMESTAMP = 1705948404 > > -SHA256 (ngtcp2-1.2.0.tar.xz) = b0e78508bcf861296eb2382a845413ecb10b2f2209928e25eedab81680650a95 > > -SIZE (ngtcp2-1.2.0.tar.xz) = 598000 > > +TIMESTAMP = 1708448948 > > +SHA256 (ngtcp2-1.3.0.tar.xz) = c3e386674103feedfedcc711190affcdec1c682af8a850469ecf1714d28c139b > > +SIZE (ngtcp2-1.3.0.tar.xz) = 615620 > > diff --git a/net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in] b/net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in] > > new file mode 100644 > > index 000000000000..afad6594b328 > > --- /dev/null > > +++ b/net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in] > > @@ -0,0 +1,13 @@ > > +--- Makefile.in.orig [http://Makefile.in.orig] 2022-01-16 12:35:06 UTC > > ++++ Makefile.in [http://Makefile.in] > > +@@ -425,8 +425,8 @@ top_srcdir = @top_srcdir@ > > + # LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION > > + # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION > > + # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > +-SUBDIRS = lib tests doc $(am__append_1) $(am__append_2) > > +-dist_doc_DATA = README.rst > > ++SUBDIRS = lib $(am__append_1) > > ++dist_doc_DATA = > > + ACLOCAL_AMFLAGS = -I m4 > > + EXTRA_DIST = \ > > + cmakeconfig.h.in [http://cmakeconfig.h.in] \ > > diff --git a/net/libngtcp2/pkg-plist b/net/libngtcp2/pkg-plist > > index 000b4a1f39b2..a36461f1b13f 100644 > > --- a/net/libngtcp2/pkg-plist > > +++ b/net/libngtcp2/pkg-plist > > @@ -3,5 +3,5 @@ include/ngtcp2/version.h > > lib/libngtcp2.a > > lib/libngtcp2.so [http://libngtcp2.so] > > lib/libngtcp2.so.16 [http://libngtcp2.so.16] > > -lib/libngtcp2.so.16.1.1 [http://libngtcp2.so.16.1.1] > > +lib/libngtcp2.so.16.1.2 [http://libngtcp2.so.16.1.2] > > libdata/pkgconfig/libngtcp2.pc Hi, Is there any reason for this change apart from adding unnecessary patching (submit upstream) and slower builds which multiple people are raised concerns about in general (see -ports mailing lists)? Best regards, Daniel [-- Attachment #2 --] <div>On 2024-02-21T16:19:24.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by sunpoet:<br></div><div><br></div><div>URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=4dc04ac964f8af7666478eff399814f102fb5eb1" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=4dc04ac964f8af7666478eff399814f102fb5eb1</a><br></div><div><br></div><div>commit 4dc04ac964f8af7666478eff399814f102fb5eb1<br></div><div>Author: Po-Chuan Hsieh <<a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-02-21 14:27:22 +0000<br></div><div>Commit: Po-Chuan Hsieh <<a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a>><br></div><div>CommitDate: 2024-02-21 15:06:37 +0000<br></div><div><br></div><div> net/libngtcp2: Update to 1.3.0<br></div><div> <br></div><div> - Convert back to autotools<br></div><div> - Remove unnecessary substitution<br></div><div> <br></div><div> Changes: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/ngtcp2/ngtcp2/releases" target="_blank">https://github.com/ngtcp2/ngtcp2/releases</a><br></div><div>---<br></div><div>; net/libngtcp2/Makefile | 17 ++++++++---------<br></div><div> net/libngtcp2/distinfo | 6 +++---<br></div><div> net/libngtcp2/files/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://patch-Makefile.in" target="_blank">patch-Makefile.in</a> | 13 +++++++++++++<br></div><div> net/libngtcp2/pkg-plist | 2 +-<br></div><div> 4 files changed, 25 insertions(+), 13 deletions(-)<br></div><div><br></div><div>diff --git a/net/libngtcp2/Makefile b/net/libngtcp2/Makefile<br></div><div>index 1deb680168a1..215e17283363 100644<br></div><div>--- a/net/libngtcp2/Makefile<br></div><div>+++ b/net/libngtcp2/Makefile<br></div><div>@@ -1,7 +1,7 @@<br></div><div> PORTNAME= ngtcp2<br></div><div>-DISTVERSION= 1.2.0<br></div><div>+PORTVERSION= 1.3.0<br></div><div> CATEGORIES= net<br></div><div>-MASTER_SITES= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/" target="_blank">https://github.com/</a>${PORTNAME}/${PORTNAME}/releases/download/v${DISTVERSION}/<br></div><div>+MASTER_SITES= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/ngtcp2/ngtcp2/releases/download/v" target="_blank">https://github.com/ngtcp2/ngtcp2/releases/download/v</a>${PORTVERSION}/<br></div><div>; PKGNAMEPREFIX= lib<br></div><div> <br></div><div> MAINTAINER= <a class="defaultMailLink" href="mailto:sunpoet@FreeBSD.org">sunpoet@FreeBSD.org</a><br></div><div>@@ -12,13 +12,12 @@ WWW= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://nghttp2.org/ngtcp2/" target="_blank">https://nghttp2.org/ngtcp2/</a>; \<br></div><div> LICENSE= MIT<br></div><div> LICENSE_FILE= ${WRKSRC}/COPYING<br></div><div> <br></div><div>-USES= cmake compiler:c++14-lang pathfix tar:xz<br></div><div>-USE_LDCONFIG= yes<br></div><div>+USES= compiler:c++14-lang libtool pathfix pkgconfig tar:xz<br></div><div> <br></div><div>-# Always disabled due to lack of QUIC support which is in 3.2<br></div><div>-CMAKE_OFF= ENABLE_OPENSSL<br></div><div>-CMAKE_ON= CMAKE_DISABLE_FIND_PACKAGE_CUnit \<br></div><div>- CMAKE_DISABLE_FIND_PACKAGE_Libev \<br></div><div>- CMAKE_DISABLE_FIND_PACKAGE_Libnghttp3<br></div><div>+CONFIGURE_ARGS= --enable-lib-only --with-jemalloc<br></div><div>+GNU_CONFIGURE= yes<br></div><div>+INSTALL_TARGET= install-strip<br></div><div>+USE_CXXSTD= c++14<br></div><div>+USE_LDCONFIG= yes<br></div><div> <br></div><div> .include <<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://bsd.port.mk>" target="_blank">bsd.port.mk></a>;<br></div><div>diff --git a/net/libngtcp2/distinfo b/net/libngtcp2/distinfo<br></div><div>index 5e02e151e88b..5b049b4b98d5 100644<br></div><div>--- a/net/libngtcp2/distinfo<br></div><div>+++ b/net/libngtcp2/distinfo<br></div><div>@@ -1,3 +1,3 @@<br></div><div>-TIMESTAMP = 1705948404<br></div><div>-SHA256 (ngtcp2-1.2.0.tar.xz) = b0e78508bcf861296eb2382a845413ecb10b2f2209928e25eedab81680650a95<br></div><div>-SIZE (ngtcp2-1.2.0.tar.xz) = 598000<br></div><div>+TIMESTAMP = 1708448948<br></div><div>+SHA256 (ngtcp2-1.3.0.tar.xz) = c3e386674103feedfedcc711190affcdec1c682af8a850469ecf1714d28c139b<br></div><div>+SIZE (ngtcp2-1.3.0.tar.xz) = 615620<br></div><div>diff --git a/net/libngtcp2/files/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://patch-Makefile.in" target="_blank">patch-Makefile.in</a> b/net/libngtcp2/files/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://patch-Makefile.in" target="_blank">patch-Makefile.in</a><br></div><div>new file mode 100644<br></div><div>index 000000000000..afad6594b328<br></div><div>--- /dev/null<br></div><div>+++ b/net/libngtcp2/files/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://patch-Makefile.in" target="_blank">patch-Makefile.in</a><br></div><div>@@ -0,0 +1,13 @@<br></div><div>+--- <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://Makefile.in.orig" target="_blank">Makefile.in.orig</a> 2022-01-16 12:35:06 UTC<br></div><div>++++ <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://Makefile.in" target="_blank">Makefile.in</a><br></div><div>+@@ -425,8 +425,8 @@ top_srcdir = @top_srcdir@<br></div><div>+ # LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION<br></div><div>+ # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION<br></div><div>+ # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.<br></div><div>+-SUBDIRS = lib tests doc $(am__append_1) $(am__append_2)<br></div><div>+-dist_doc_DATA = README.rst<br></div><div>++SUBDIRS = lib $(am__append_1)<br></div><div>++dist_doc_DATA =<br></div><div>+ ACLOCAL_AMFLAGS = -I m4<br></div><div>+ EXTRA_DIST = \<br></div><div>+ <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://cmakeconfig.h.in" target="_blank">cmakeconfig.h.in</a> \<br></div><div>diff --git a/net/libngtcp2/pkg-plist b/net/libngtcp2/pkg-plist<br></div><div>index 000b4a1f39b2..a36461f1b13f 100644<br></div><div>--- a/net/libngtcp2/pkg-plist<br></div><div>+++ b/net/libngtcp2/pkg-plist<br></div><div>@@ -3,5 +3,5 @@ include/ngtcp2/version.h<br></div><div> lib/libngtcp2.a<br></div><div> lib/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://libngtcp2.so" target="_blank">libngtcp2.so</a><br></div><div> lib/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://libngtcp2.so.16" target="_blank">libngtcp2.so.16</a><br></div><div>-lib/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://libngtcp2.so.16.1.1" target="_blank">libngtcp2.so.16.1.1</a><br></div><div>+lib/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://libngtcp2.so.16.1.2" target="_blank">libngtcp2.so.16.1.2</a><br></div><div> libdata/pkgconfig/libngtcp2.pc<br></div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>Is there any reason for this change apart from adding unnecessary patching (submit upstream) and slower builds which multiple people are raised concerns about in general (see -ports mailing lists)?<br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div><div><br></div><div><br></div><div ><div><br></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fada341992606fed9aa13f4a9460b58f>