Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Jan 2024 00:10:11 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 91d2a093dfac - main - isp: Fix endianness conversion in isp_read_flash_data()
Message-ID:  <202401010010.4010AB7Q020141@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=91d2a093dfaccdf288db663b6e9d47539ea1c1bf

commit 91d2a093dfaccdf288db663b6e9d47539ea1c1bf
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-12-31 23:52:52 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2023-12-31 23:59:06 +0000

    isp: Fix endianness conversion in isp_read_flash_data()
    
    Reported by:    Jenkins
    Fixes:  10ed63fc06cb ("isp(4): Rework firmware handling/loading")
---
 sys/dev/isp/isp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/isp/isp.c b/sys/dev/isp/isp.c
index aa2f1fb74c59..b53171add5f5 100644
--- a/sys/dev/isp/isp.c
+++ b/sys/dev/isp/isp.c
@@ -4575,7 +4575,7 @@ isp_read_flash_data(ispsoftc_t *isp, uint32_t *dwptr, uint32_t faddr, uint32_t d
 		rval = isp_read_flash_dword(isp, faddr, dwptr);
 		if (rval != ISP_SUCCESS)
 			break;
-		htole32(*((uint32_t *)(dwptr)));
+		*dwptr = htole32(*dwptr);
 	}
 
 	return (rval);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202401010010.4010AB7Q020141>