Date: Tue, 13 May 2003 08:35:46 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: des@ofug.org Cc: obrien@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4 umass.4 src/sys/dev/usb umass.c usbdevs Message-ID: <20030513.083546.133906327.imp@bsdimp.com> In-Reply-To: <xzphe7zmb45.fsf@flood.ping.uio.no> References: <20030512.223927.39164038.imp@bsdimp.com> <xzpllxbmcqr.fsf@flood.ping.uio.no> <xzphe7zmb45.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <xzphe7zmb45.fsf@flood.ping.uio.no>
Dag-Erling Smorgrav <des@ofug.org> writes:
: Dag-Erling Smorgrav <des@ofug.org> writes:
: > "M. Warner Losh" <imp@bsdimp.com> writes:
: > > This patch doesn't address those drivers that might wish to build not
: > > in the usb.ko module, for example the urio driver and I'm sure others.
: > I know. I did mention that it was incomplete, didn't I?
:
: This one should be a little better. The second patch fixes the
: #include lines. It would be advantageous if the awk script could
: generate usbdevs.h and usbdevs_data.h separately, as the latter is
: only required by the usb driver and it's a waste of time and space to
: generate it for all the other drivers.
The makefiles for the modules still need to be included. I think I
like my approach a little better, but it has the flaw of not
necessarily generating usbdevs_data.h if usbdevs.h isn't generated.
Since usbdevs_data.h is used only when USBVERBOSE is defined, I would
have thought that we'd not need it (since USBVERBOSE is supposed to be
an option), but it looks like it is always defined, so we get a lot of
extra junk in our usb.ko module, even on install media...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030513.083546.133906327.imp>