Date: Wed, 10 Jul 2013 18:45:17 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Aleksandr Rybalko <ray@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r252425 - head/sys/arm/arm Message-ID: <20130710184356.R1991@besplex.bde.org> In-Reply-To: <20130708132052.f9757df88ede1b087de9da8c@freebsd.org> References: <201306301952.r5UJqfwf010873@svn.freebsd.org> <20130701113808.F894@besplex.bde.org> <20130708132052.f9757df88ede1b087de9da8c@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 8 Jul 2013, Aleksandr Rybalko wrote:
> On Mon, 1 Jul 2013 11:56:25 +1000 (EST)
> Bruce Evans <brde@optusnet.com.au> wrote:
>
>> On Sun, 30 Jun 2013, Aleksandr Rybalko wrote:
>>
>>> Log:
>>> Decrypt magic numbers - define names for fields of Generic Timer's CNTKCTL reg.
>>>
>>> Submitted by: Ruslan Bukin <br@bsdpad.com>
>>>
>>> Modified:
>>> head/sys/arm/arm/generic_timer.c
>>>
>>> Modified: head/sys/arm/arm/generic_timer.c
>>> ==============================================================================
>>> --- head/sys/arm/arm/generic_timer.c Sun Jun 30 19:36:17 2013 (r252424)
>>> +++ head/sys/arm/arm/generic_timer.c Sun Jun 30 19:52:41 2013 (r252425)
>>> @@ -66,7 +66,22 @@ __FBSDID("$FreeBSD$");
>>> #define GENERIC_TIMER_REG_CTRL 0
>>> #define GENERIC_TIMER_REG_TVAL 1
>>>
>>> -#define CNTPSIRQ 29
>>> +#define GENERIC_TIMER_CNTKCTL_PL0PTEN (1 << 9) /* Physical timer registers
>>> + access from PL0 */
>>> +#define GENERIC_TIMER_CNTKCTL_PL0VTEN (1 << 8) /* Virtual timer registers
>>
>> With names like these, the magic numbers are better. The prefix name
>> GENERIC_TIMER is especially bad. GT would be good.
>
> Changed in r252780.
Thanks. It looks OK now.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130710184356.R1991>