Date: Wed, 26 Apr 2017 09:10:03 +0000 From: "oshogbo (Mariusz Zaborski)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D10485: Replace dhcp option 150 by 66 Message-ID: <fda0355dabb6edcb00b95ef84facc594@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-rdfe23ryefhflnjblbcr-req@FreeBSD.org> References: <differential-rev-PHID-DREV-rdfe23ryefhflnjblbcr-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
oshogbo added inline comments.
INLINE COMMENTS
> bootp.h:99
> +
> +#define VEND_INFO_END 0xff /* End option in RFC2132 */
>
Let's use 255 instead of hexa value as described in rfc:
> Code 255 (END), if present, signifies the end of the
>
> encapsulated vendor extensions, not the end of the vendor
> extensions field. If no code 255 is present, then the end of
> the enclosing vendor-specific information field is taken as the
> end of the encapsulated vendor-specific extensions field.
Lets also use the file standard:
#define VEND_INFO_END ((unsigned char) 255) /* End option in RFC2132 */
REVISION DETAIL
https://reviews.freebsd.org/D10485
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp
Cc: rgrimes, garga, ler, asomers
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fda0355dabb6edcb00b95ef84facc594>