Date: Mon, 16 Aug 2004 09:31:15 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: jhb@freebsd.org Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ... Message-ID: <20040816.093115.53587779.imp@bsdimp.com> In-Reply-To: <200408160951.12155.jhb@FreeBSD.org> References: <20040816052054.GR991@funkthat.com> <20040816054318.GF980@green.homeunix.org> <200408160951.12155.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200408160951.12155.jhb@FreeBSD.org> John Baldwin <jhb@FreeBSD.org> writes: : On Monday 16 August 2004 01:43 am, Brian Fundakowski Feldman wrote: : > On Sun, Aug 15, 2004 at 10:20:55PM -0700, John-Mark Gurney wrote: : > > Brian Fundakowski Feldman wrote this message on Sun, Aug 15, 2004 at 22:38 : -0400: : > > > On Sun, Aug 15, 2004 at 06:51:08PM -0700, John-Mark Gurney wrote: : > > > > sure, I'd like a quick peak at the patch though (if it takes me more : > > > > than a day, go ahead and commit). : > > > : > > > I'd very much like you to look it over. I haven't tested it, just made : > > > the stylistic changes. If it were more complete (i.e. satisfy bde), : > > > every spurious blank line (that is, all of them inside functions which : > > > are not between variable declarations and code) would be gone, too, but : > > > that can be kind of harsh. : > > : > > As was pointed out... blank lines at the top of functions w/o variables : > > are mandated by style(9)... : > : > The manpage is either wrong or misleading, so either way, I'm waiting : > to hear from bde. : : I've never been confused on that topic Brian. Just accept it and move on. It has come up about a dozen times and matches large parts of the tree that style(9) was designed to document. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040816.093115.53587779.imp>