Date: Thu, 13 Dec 2012 22:31:47 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, jhb@FreeBSD.org Subject: Re: svn commit: r244154 - head/bin/ps Message-ID: <20121213213147.GA1401@garage.freebsd.pl> In-Reply-To: <20121213181621.GG71906@kib.kiev.ua> References: <201212121545.qBCFj4Hl086444@svn.freebsd.org> <20121212210652.GO3013@kib.kiev.ua> <20121213111240.GB1381@garage.freebsd.pl> <20121213161242.GE71906@kib.kiev.ua> <20121213165541.GD1381@garage.freebsd.pl> <20121213181621.GG71906@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 13, 2012 at 08:16:21PM +0200, Konstantin Belousov wrote: > On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: > > On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: > > > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > > > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > > > I saw CTLFLAG_TUN on the sysctl and assumed it is read-only... > > > > How about defining BSD_PID_MAX in sys/proc.h, which would be visibl= e by > > > > userland as well and setting PID_MAX to BSD_PID_MAX? > > > >=20 > > > > This would also help bsnmpd. > > > >=20 > > > > http://people.freebsd.org/~pjd/patches/PID_MAX.patch > > > Do you know why PID_MAX is under _KERNEL ? If there is no real reason, > > > it would be better to move it outside kernel-only section. sys/proc.h > > > is not in POSIX anyway. > >=20 > > I assumed it will break some ports that may define it themselves. > > I wonder if we could do a test ports build to see what's the impact. >=20 > Sure. >=20 > On the other hand, sys/proc.h is mostly useless for the application code > as it is now. Might be, use > #ifndef PID_MAX > braces ? This can be done of course, but it won't help cases where PID_MAX is defined after sys/proc.h is included. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDKSUMACgkQForvXbEpPzRu4wCffzwr68b3FD1J5XNwJVeklX3M Cp0AoI77Uc00qIo84676rt1Fq/viIpEe =EYUL -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121213213147.GA1401>