Date: Tue, 12 Jun 2012 23:44:00 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org Subject: Re: svn commit: r236935 - head/sys/kern Message-ID: <20120612214400.GB1429@garage.freebsd.pl> In-Reply-To: <20120612191828.GD20749@dft-labs.eu> References: <201206112205.q5BM5QIv013266@svn.freebsd.org> <4FD6FD39.5090800@gmail.com> <20120612104749.GB20749@dft-labs.eu> <20120612114335.GA1372@garage.freebsd.pl> <20120612134950.GC20749@dft-labs.eu> <20120612160128.GA1429@garage.freebsd.pl> <20120612191828.GD20749@dft-labs.eu>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote: > On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote: > > Look good and you can just add 'In co-operation with: pjd'. > > One minor thing is that fd_first_free() can return 'size' if there are > > no free slots available. Could you include that in the comment as well? > > > > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free2.patch Ok. Merge racct_set() call into one line, it now fits into 80 chars. I have no more objections. > > > fd_last_used has very same problem with comment as fd_first_free. This > > > function is static and the only caller always passes 0 as low. Given > > > that, how about the following: > > > http://people.freebsd.org/~mjg/patches/fd_last_used-cleanup.patch > > > > Looks good too. > > > > Updated in similar manner: > http://people.freebsd.org/~mjg/patches/fd_last_used-cleanup2.patch Ok. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/XuB8ACgkQForvXbEpPzRj0gCeK86N67zB4OQTukA3B9jX1Ih1 jDYAoPi14muxXnESwmNYqv3rjjSqUuTP =gzMA -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120612214400.GB1429>