Date: Thu, 17 Aug 2023 08:03:40 +0200 From: Felix Palmen <zirias@freebsd.org> To: ports@freebsd.org Subject: Re: plist-check not reporting orphaned files present in a @comment Message-ID: <yccoastr67igymrpia64kkxofded42fzrcboc4fmvwbn4uop4f@ug5j362pkjgr> In-Reply-To: <SI2PR01MB50367346DECCA8B8A4FC29FDFA15A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com> References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org> <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> <SI2PR01MB50367346DECCA8B8A4FC29FDFA15A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--a4za77ruynh7qh4h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
* Tatsuki Makino <tatsuki_makino@hotmail.com> [20230817 07:57]:
> Switching @comment by ${ARCH} is also in print/epson-inkjet-printer-escpr=
2.
> This is not a problem with check-orphans.
It is, when some file doesn't exist for all architectures, but for more
than one of them.
You first test the port on ARCH=3Dfoo. Then you test on ARCH=3Dbar and find
that it builds/installs an additional tmp/something, so you prefix it
with %%BAR%% which expands to "@comment " unless building on ARCH=3Dbar.
Then you test on ARCH=3Dbaz which happens to build/install the same
tmp/something. plist-check will still be happy because the file is there
in pkg-plist (ignoring the @comment). Still, the file will be missing
=66rom the package.
I might try another workaround, e.g. expand to "@comment dummy/"
instead, so the name won't match and plist-check will complain ...
> However, linuxulator ports often switch plist file itself for different $=
{ARCH}.
Sure, but that's only suitable when a large portion of entries is indeed
different depending on ${ARCH}.
--=20
Felix Palmen <zirias@FreeBSD.org> {private} felix@palmen-it.de
-- ports committer -- {web} http://palmen-it.de
{pgp public key} http://palmen-it.de/pub.txt
{pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231
--a4za77ruynh7qh4h
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iNUEABYKAH0WIQRpNhPVW79IN7ISOsxUreAGmHnyMQUCZN24NV8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0Njkz
NjEzRDU1QkJGNDgzN0IyMTIzQUNDNTRBREUwMDY5ODc5RjIzMQAKCRBUreAGmHny
MdtZAP404zzFbCkfXi03BKhcqX2tnvtO82+Om5BwBL9V95BCiQD+IOVX6Fl1pqWN
MaFVSsnPJGT9v5yI4gwWBjUX+zT/WwA=
=J536
-----END PGP SIGNATURE-----
--a4za77ruynh7qh4h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?yccoastr67igymrpia64kkxofded42fzrcboc4fmvwbn4uop4f>