Date: Sun, 3 Mar 2024 11:28:51 +0100
From: Mathieu Arnold <mat@freebsd.org>
To: Gleb Popov <arrowd@freebsd.org>
Cc: Thomas Zander <riggs@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG
Message-ID: <cwtyj6bhvrkhndpkdhb5ly6pllqseaa2hd7cgyayftbqm3trnh@4osqtfee6nou>
In-Reply-To: <CALH631mJShhLMkULtyBSyc1H%2BH4fZBfrt=adxTGe1WxVYcPXQw@mail.gmail.com>
References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> <CALH631k%2BK%2Bf2Tpmk9HGX%2BWydcB8xe-xquRSKYitUzXGc7eO4bQ@mail.gmail.com> <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk> <CALH631mJShhLMkULtyBSyc1H%2BH4fZBfrt=adxTGe1WxVYcPXQw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--5r3h42gm5ya4dolv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 03, 2024 at 12:01:41PM +0300, Gleb Popov wrote: > On Sun, Mar 3, 2024 at 11:56=E2=80=AFAM Mathieu Arnold <mat@freebsd.org> = wrote: > > > > There is no trend, it's a rule, debug must be handled with WITH_DEBUG > > knob, and not via an option. > > If there is an option that enable some sort of debugging or verbose > > thing but that is not supposed to add debugging symbols, then it should > > not be called DEBUG. >=20 > In that case we need a qa check that prevents adding DEBUG option and > then we can also introduce a generic DEBUG_VAR helper to get rid of > ifdefs? What do you mean DEBUG_VAR ? --=20 Mathieu Arnold --5r3h42gm5ya4dolv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXkUOJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6S+gv9HTHc74s6H+ZxVBlDSsEQx2J5i1VZXEy0PA9nIctuIqn3Jh9URMXr7JGQ AdAAwR1Aem3qYzOqqmVXZlCMxsGTXuvUU9pCVa4iIS1RDaPRUMZzYsJfS1M7G6We HMtc4lW0bg0qzsUYy8pivMN0ka30z2FuLfcgPo3EyEJ3Xr6nuzyJ/Mq55mhED8ZY x8uTTZCNx7JxAa6qF253iP+eYrW+RSYEW0hEcfqvrJRChwV5cDIM/2zNry/k+esO Pyox+W1TFy4l8tGJBfP/yqYTpJ1J2NPBwad4orLwvZImOcQExfsB4uG1+LFc+Ck5 ifdcDGsk4hFPL2vWuA7OBp+MKJQx2gbBiBbm37WbpbOkEUYnf2y6SqqDqQK2p/fG NLb+nR9vI/HzT9RukeG6t7Fzlym7MUM5/tfwvtAG2lekutklnxRj5JU18KJR7b8Q Xs439ZnnFz17KT6V8bi5OYIkvBK70VMqfdYMnnK8HF8I6guoqOxa9x40kH28FjPf XHwTcyYx =A4W8 -----END PGP SIGNATURE----- --5r3h42gm5ya4dolv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cwtyj6bhvrkhndpkdhb5ly6pllqseaa2hd7cgyayftbqm3trnh>