Date: Thu, 5 Sep 2013 18:44:39 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255246 - head/sys/sys Message-ID: <20130905144439.GD4574@FreeBSD.org> In-Reply-To: <20130905140319.GX41229@kib.kiev.ua> References: <201309051346.r85DkU6U045151@svn.freebsd.org> <20130905140319.GX41229@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 05, 2013 at 05:03:19PM +0300, Konstantin Belousov wrote: K> On Thu, Sep 05, 2013 at 01:46:30PM +0000, Gleb Smirnoff wrote: K> > Author: glebius K> > Date: Thu Sep 5 13:46:30 2013 K> > New Revision: 255246 K> > URL: http://svnweb.freebsd.org/changeset/base/255246 K> > K> > Log: K> > Fix build. K> > counter.h requires systm.h K> > K> > Modified: K> > head/sys/sys/sf_buf.h K> > K> > Modified: head/sys/sys/sf_buf.h K> > ============================================================================== K> > --- head/sys/sys/sf_buf.h Thu Sep 5 12:56:08 2013 (r255245) K> > +++ head/sys/sys/sf_buf.h Thu Sep 5 13:46:30 2013 (r255246) K> > @@ -54,6 +54,7 @@ struct sfstat { /* sendfile statistic K> > K> > #ifdef _KERNEL K> > #include <machine/sf_buf.h> K> > +#include <sys/systm.h> K> > #include <sys/counter.h> K> > struct mbuf; /* for sf_buf_mext() */ K> > K> IMO the counter.h (and sfstat, SFSTAT_INC) should be removed from the sf_buf.h. The problem is that SFSTAT_INC() is used in MD code. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130905144439.GD4574>