Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Mar 2015 02:49:06 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r280882 - head/cddl/contrib/opensolaris/lib/libdtrace/common
Message-ID:  <201503310249.t2V2n6Z6085197@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Tue Mar 31 02:49:05 2015
New Revision: 280882
URL: https://svnweb.freebsd.org/changeset/base/280882

Log:
  Fix a misparenthesization that could cause a crash if TERM is not set.
  
  Reported by:	Coverity (internal)
  MFC after:	3 days
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c

Modified: head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c
==============================================================================
--- head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c	Tue Mar 31 01:44:29 2015	(r280881)
+++ head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c	Tue Mar 31 02:49:05 2015	(r280882)
@@ -727,8 +727,8 @@ dt_print_packed(dtrace_hdl_t *dtp, FILE 
 			utf8 = B_TRUE;
 		} else if ((term = getenv("TERM")) != NULL &&
 		    (strcmp(term, "sun") == 0 ||
-		    strcmp(term, "sun-color") == 0) ||
-		    strcmp(term, "dumb") == 0) {
+		    strcmp(term, "sun-color") == 0 ||
+		    strcmp(term, "dumb") == 0)) {
 			utf8 = B_FALSE;
 		} else {
 			utf8 = B_TRUE;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201503310249.t2V2n6Z6085197>