Date: Sun, 17 Nov 2002 14:53:58 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Jake Burkholder <jake@locore.ca> Cc: current@FreeBSD.ORG, sparc64@FreeBSD.ORG Subject: Re: sparc64 tinderbox failure Message-ID: <Pine.BSF.4.21.0211171449580.53326-100000@InterJet.elischer.org> In-Reply-To: <20021117154655.B2737@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 17 Nov 2002, Jake Burkholder wrote:
> Apparently, On Sun, Nov 17, 2002 at 12:23:20PM -0800,
> Julian Elischer said words to the effect of;
>
> >
> >
> > On Sun, 17 Nov 2002, Mike Barcroft wrote:
> > > --------------------------------------------------------------
> > > >>> Kernel build for GENERIC started on Sun Nov 17 20:01:33 GMT 2002
> > > --------------------------------------------------------------
> > > ===> ipfilter
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c: In function `kse_create':
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: `mp_ncpus' undeclared (first use in this function)
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: (Each undeclared identifier is reported only once
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: for each function it appears in.)
> >
> >
> > ok mea culpa..
> >
> > what is there in SPARC that should be used instead..?
>
> mp_ncpus is defined in sys/smp.h which is not included kern_thread.c
> I don't see why this builds on any platform.
>
#if 0 /* while debugging */
#ifdef SMP
if (kg->kg_kses > mp_ncpus)
#endif
return (EPROCLIM);
#endif
(last night)
seems to have changed in the last 12 hours to:
#ifdef SMP
if (kg->kg_kses > mp_ncpus)
#endif
return (EPROCLIM);
i.e. the #if 0 seems to have disappeared...
I guess that David Xu forgot to include smp.h
in his patch.
> Jake
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0211171449580.53326-100000>