Date: Wed, 2 Mar 2011 15:09:21 -0600 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: Bernhard Froehlich <decke@bluelife.at> Cc: freebsd-emulation@freebsd.org, Julian Elischer <julian@freebsd.org>, freebsd-virtualization@freebsd.org Subject: Re: VirtualBox + VIMAGE Message-ID: <AANLkTi=RAeFRyaFaNtx==ciq6d-wBd-im-o3_b7G=YB9@mail.gmail.com> In-Reply-To: <8b39481bb24314e2d543b7544f12a447@bluelife.at> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <4D3F8357.2070005@freebsd.org> <62fcd16074e526547c3417a8f259174e@bluelife.at> <8662tbkahz.fsf@zhuzha.ua1> <c51ff723c5ffb7109b7be6e3cf8f7014@bluelife.at> <AANLkTimZG0cwXhNdaF5Uv16HfJ299oeexrUSMc7MKE_Q@mail.gmail.com> <4c9ee35c7798936a1e35259d72af781c@bluelife.at> <8b39481bb24314e2d543b7544f12a447@bluelife.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 2, 2011 at 2:52 PM, Bernhard Froehlich <decke@bluelife.at> wrot= e: > On Wed, 02 Mar 2011 21:31:45 +0100, Bernhard Froehlich wrote: >> On Wed, 2 Mar 2011 08:30:01 -0600, Brandon Gooch wrote: >>> On Wed, Jan 26, 2011 at 5:19 PM, Bernhard Froehlich >>> <decke@freebsd.org> wrote: >>>> On Wed, 26 Jan 2011 16:25:28 +0200, Mikolaj Golub wrote: >>>>> On Wed, 26 Jan 2011 10:22:40 +0100 Bernhard Froehlich wrote: >>>>> >>>>> =A0BF> Sounds like it's my turn now. Which FreeBSD version is require= d to be >>>>> =A0BF> able to use it? >>>>> >>>>> As Bjoern noted it is for __FreeBSD_version >=3D 800500. >>>>> >>>>> =A0BF> Is VIMAGE enabled per default and what happens if VIMAGE is di= sabled - >>>>> =A0BF> does it at least build fine with that patch? >>>>> >>>>> We have VIMAGE disabled by default. >>>>> >>>>> I have added to src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile: >>>>> >>>>> .if defined(VIMAGE) >>>>> =A0CFLAGS +=3D -DVIMAGE >>>>> .endif >>>>> >>>>> So to build the driver for VIMAGE enabled kernel one should run >>>>> >>>>> VIMAGE=3D1 make >>>>> >>>>> If VIMAGE variable is not defined the module for VIMAGE disabled kern= el will >>>>> be built. >>>> >>>> http://home.bluelife.at/patches/virtualbox-ose-kmod-devel-VIMAGE.diff >>>> >>>> I've integrated it a bit better into the VirtualBox build system, adde= d >>>> the ports stuff and updated the patch for VirtualBox 4.0.2. >>>> >>>> It is currently unclear to me why you add VIMAGE to CFLAGS but nowhere >>>> check for VIMAGE in VBoxNetFlt-freebsd.c. Shouldn't we add a check for >>>> VIMAGE in the #if defined line or is this already done somewhere deep = in >>>> the included headers? >>>> >>>> -- >>>> Bernhard Froehlich >>>> http://www.bluelife.at/ >>> >>> I managed to completely miss your patch posted this thread, so I just >>> gave it a try on bluelife's virtualbox-ose-kmod svn r1239; it's >>> working well. I've started each of my guests with bridged networking >>> to be sure, and I see no panic (or any other anomaly) during boot or >>> normal operation. >>> >>> Do you have plans on merging the patch soon? >> >> It's not committed because it doesn't work. What i have tested so far >> is with stock 8.2-REL so without VIMAGE. >> >> enabled VIMAGE option on stock 8.2-REL: bridging works fine >> disabled VIMAGE option on stock 8.2-REL: crashes vm with an assert >> >> Expression: !pPatchToGuestRec >> Location =A0: >> /usr/home/decke/blueports/emulators/virtualbox-ose/work/VirtualBox-4.0.4= _OSE/src/VBox/VMM/VMMR3/PATM.cpp(116 >> 6) void patmr3AddP2GLookupRecord(VM*, _PATCHINFO*, uint8_t*, RTRCPTR, >> PATM_LOOKUP_TYPE, bool) > > It looks like that assert is not related to the VIMAGE patch. Works > fine now since half an hour. > >> Could someone with an VIMAGE kernel please test the patch? Just >> configure a VM with bridging and let it transfer a few bytes. Once with >> the option enabled and once disabled. I've had a machine running a linux guest for almost a day, bridging with a VIMAGE kernel, while capturing traffic on the virtual interface (and performing a few other tasks) -- so far, so good. No panics, and no anomalies. I surely don't know what the above mentioned assert is about; I haven't seen such a panic myself. -Brandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=RAeFRyaFaNtx==ciq6d-wBd-im-o3_b7G=YB9>