Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Feb 2026 17:44:45 -0800
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        Michael Tuexen <tuexen@freebsd.org>
Cc:        "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: 454212b9718b - main - sctp: fix so_proto when peeling off a socket
Message-ID:  <aaJIjSrqeYvXdOPg@cell.glebi.us>
In-Reply-To: <BAFD25A7-7EE5-4B9C-9EFB-70B96F92AAD0@FreeBSD.org>
References:  <699ef25d.42e41.7579887f@gitrepo.freebsd.org> <DA9B5022-602F-4720-9473-191B1A20B6B5@gmail.com> <BAFD25A7-7EE5-4B9C-9EFB-70B96F92AAD0@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

On Fri, Feb 27, 2026 at 08:11:39AM +0100, Michael Tuexen wrote:
M> >> - so = sopeeloff(head);
M> >> + so = sopeeloff(head, &sctp_stream_protosw);
M> > 
M> > This part of the change broke LINT-NOINET because sctp_stream_protosw is only defined in the INET case. I didn’t dig into the SCTP syscalls too far, but I think that the right protocol needs to be picked per the address family, right?

btw, I tried to move the function to sctp_syscalls.c and this required exposing
soattach() and soalloc() outside.  After weighting in and out decided to leave
it the way it is.

-- 
Gleb Smirnoff


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aaJIjSrqeYvXdOPg>