Date: Mon, 26 Apr 2010 16:18:03 -0500 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: Jacques Fourie <jacques.fourie@gmail.com> Cc: freebsd-net@freebsd.org Subject: Re: m_copymdata() bug? Message-ID: <n2x179b97fb1004261418p18b37bd0id268878a2b509006@mail.gmail.com> In-Reply-To: <s2tbe2f52431004130630z7795c52fqbcfefebd8ddf25@mail.gmail.com> References: <s2tbe2f52431004130630z7795c52fqbcfefebd8ddf25@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 13, 2010 at 8:30 AM, Jacques Fourie <jacques.fourie@gmail.com> wrote: > It seems as if the m_copymdata() function defined in uipc_mbuf.c has a > bug. It uses m_apply to copy data from the source mbuf to the target > but in the callback function m_bcopyxxx() the arguments are > interpreted in the wrong order. Swapping the 's' and 't' arguments in > the declaration of m_bcopyxxx() fixes the problem for me. Perhaps you should file a PR with an included patch: http://www.freebsd.org/doc/en_US.ISO8859-1/articles/problem-reports/article.html http://www.freebsd.org/send-pr.html Thanks! -Brandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?n2x179b97fb1004261418p18b37bd0id268878a2b509006>