Date: Fri, 21 Sep 2007 14:03:00 +0300 From: Cristian KLEIN <cristi@net.utcluj.ro> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: freebsd-acpi@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: [PATCH] OsdSynch.c modernization Message-ID: <46F3A4E4.5030702@net.utcluj.ro> In-Reply-To: <200709181734.57392.jkim@FreeBSD.org> References: <200709181516.11207.jkim@FreeBSD.org> <46F041BC.6070604@net.utcluj.ro> <200709181734.57392.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jung-uk Kim wrote: > On Tuesday 18 September 2007 05:23 pm, Cristian KLEIN wrote: >> Jung-uk Kim wrote: >>> I have rewritten sys/dev/acpica/Osd/OsdSynch.c to match the >>> modern ACPI-CA and -CURRENT: >>> >>> http://people.freebsd.org/~jkim/acpica/OsdSynch.diff >>> >>> Major changes are: >>> >>> 1. Semaphore is reimplemented with convar(9) instead of mutex(9). >>> >>> 2. Semaphore with ACPI_WAIT_FOREVER option actually waits forever >>> now. >>> >>> 3. Obsolete and/or hidden debugging knobs and macros are removed. >>> >>> 4. ACPI-CA introduced AcpiOs*Mutex() to complement >>> AcpiOs*Semaphore(): >>> >>> http://bugzilla.kernel.org/show_bug.cgi?id=6634 >>> >>> These functions are implemented and turned on by default. >>> >>> 5. Spinlock is reimplemented with sx lock and more closely >>> implements the intended behaviour (e.g., save/restore >>> interrupts). >>> >>> It is orthogonal to Nate's effort of rewriting acpi_ec.c but I'd >>> like get more feedback *with* his last patch (revision D) because >>> his patch will be committed sooner or later. ;-) >>> >>> Please test/review and let us know if there is any regression or >>> not. >> Sorry for not being able to test the patch. May I assume this will >> fix: >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=114113 >> http://www.freebsd.org/cgi/query-pr.cgi?pr=114649 > > I believe my patch AND Nate's patch will fix the problem. Hi, I tested your patch and it works flawless. However, before applying your patch, the "recursive lock on non-recursive mutex" did not occur either.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46F3A4E4.5030702>