Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Oct 2025 08:14:55 GMT
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: dfd822b1f084 - main - ipfw: do not use errno value for error reporting
Message-ID:  <202510140814.59E8EtEl050398@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by ae:

URL: https://cgit.FreeBSD.org/src/commit/?id=dfd822b1f0846bdaa9a14457346f7431a86d3a64

commit dfd822b1f0846bdaa9a14457346f7431a86d3a64
Author:     Boris Lytochkin <lytboris@gmail.com>
AuthorDate: 2025-10-14 08:02:20 +0000
Commit:     Andrey V. Elsukov <ae@FreeBSD.org>
CommitDate: 2025-10-14 08:02:20 +0000

    ipfw: do not use errno value for error reporting
    
    table_do_modify_record() already uses errno value on error.
    Also this fixes problem when `ipfw table add` returns ENOTTY that
    is unrelated to operation.
    
    Tested by:      dhw
    Fixes:          09025a714708
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D53050
---
 sbin/ipfw/tables.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sbin/ipfw/tables.c b/sbin/ipfw/tables.c
index 7c3b1bb35a01..245c0c9e0399 100644
--- a/sbin/ipfw/tables.c
+++ b/sbin/ipfw/tables.c
@@ -1037,9 +1037,6 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add,
 		}
 	}
 
-	/* Get real OS error */
-	error = errno;
-
 	/* Report results back */
 	ptent = tent_buf;
 	for (i = 0; i < count; ptent++, i++) {


help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202510140814.59E8EtEl050398>