Date: Sun, 14 Oct 2018 12:58:25 +0300 From: Lev Serebryakov <lev@FreeBSD.org> To: "Kristof Provost" <kristof@sigsegv.be> Cc: freebsd-hackers@FreeBSD.org Subject: Re: What are ck_queue.h guarantees? Message-ID: <1822540947.20181014125825@serebryakov.spb.ru> In-Reply-To: <AD1EC8D5-C137-4128-90C9-0FCAECC5754C@sigsegv.be> References: <1551957390.20181013184006@serebryakov.spb.ru> <AD1EC8D5-C137-4128-90C9-0FCAECC5754C@sigsegv.be>
index | next in thread | previous in thread | raw e-mail
Hello Kristof, Sunday, October 14, 2018, 9:14:31 AM, you wrote: >> But in all places at kernel I peeked, CK_XXXX macros are protected by >> locks. Yes, even read ones. > Note that the implementation of if_maddr_rlock() doesn’t actually take a > lock. Instead it calls epoch_enter_preempt(). Oh, I've should look inside these functions before asking. Thank you for pointing me out. > I suspect the ‘lock’/‘unlock’ naming is mostly historical here: i.e. it > used to be a real lock, and when it was replaced by the epoch-based > approach the functions were not renamed. Yep, and it is very misleading :-) -- Best regards, Lev mailto:lev@FreeBSD.orghelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1822540947.20181014125825>