Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Sep 2024 16:05:17 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: a73a70472c47 - stable/13 - umtx: shm: 'ushm_refcnt > 0' => 'ushm_refcnt != 0'
Message-ID:  <202409041605.484G5H3R039623@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=a73a70472c47877d57d090ef77ae503fe75e9f41

commit a73a70472c47877d57d090ef77ae503fe75e9f41
Author:     Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2024-09-04 14:38:12 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-09-04 16:02:43 +0000

    umtx: shm: 'ushm_refcnt > 0' => 'ushm_refcnt != 0'
    
    'ushm_refcnt' is unsigned.  Don't leave the impression it isn't.
    
    No functional change (intended).
    
    Reviewed by:    kib
    Approved by:    emaste (mentor)
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D46126
    
    (cherry picked from commit c75a18905e308f69b01f19c3d7d613883a008e79)
    (cherry picked from commit 4938f554469bc81783998143968ec3eba2a43def)
---
 sys/kern/kern_umtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/kern/kern_umtx.c b/sys/kern/kern_umtx.c
index 5d83842f8ed2..23087cf4269e 100644
--- a/sys/kern/kern_umtx.c
+++ b/sys/kern/kern_umtx.c
@@ -4360,7 +4360,7 @@ umtx_shm_find_reg_locked(const struct umtx_key *key,
 		    reg->ushm_key.info.shared.offset ==
 		    key->info.shared.offset) {
 			KASSERT(reg->ushm_key.type == TYPE_SHM, ("TYPE_USHM"));
-			KASSERT(reg->ushm_refcnt > 0,
+			KASSERT(reg->ushm_refcnt != 0,
 			    ("reg %p refcnt 0 onlist", reg));
 			KASSERT((reg->ushm_flags & USHMF_LINKED) != 0,
 			    ("reg %p not linked", reg));
@@ -4408,7 +4408,7 @@ static bool
 umtx_shm_unref_reg_locked(struct umtx_shm_reg *reg, bool linked_ref)
 {
 	mtx_assert(&umtx_shm_lock, MA_OWNED);
-	KASSERT(reg->ushm_refcnt > 0, ("ushm_reg %p refcnt 0", reg));
+	KASSERT(reg->ushm_refcnt != 0, ("ushm_reg %p refcnt 0", reg));
 
 	if (linked_ref) {
 		if ((reg->ushm_flags & USHMF_LINKED) == 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202409041605.484G5H3R039623>