Date: Fri, 23 Jan 2026 12:42:28 +0100 From: Andre Albsmeier <mail@fbsd2.e4m.org> To: Warner Losh <imp@bsdimp.com> Cc: Andre Albsmeier <mail@fbsd2.e4m.org>, freebsd-stable@freebsd.org Subject: Re: kern.msgbuf_show_timestamp=1 Message-ID: <aXNepI5fqYoiNWt3@voyager.c4ef04bb578971607fc6a73f3188a722> In-Reply-To: <CANCZdfphXp7xy9kRDaGcaar3gjnuRaQ0mbwa0rAEOB2gcNFHUQ@mail.gmail.com> References: <202512192037.5BJKbfKY025861@donotpassgo.dyslexicfish.net> <aXHj4Zb1l4_8U6RS@voyager.c4ef04bb578971607fc6a73f3188a722> <CANCZdfphXp7xy9kRDaGcaar3gjnuRaQ0mbwa0rAEOB2gcNFHUQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Thu, 22-Jan-2026 at 08:31:15 -0700, Warner Losh wrote: > On Thu, Jan 22, 2026 at 1:46 AM Andre Albsmeier <mail@fbsd2.e4m.org> wrote: > > ... > > > > FWIW, this is a patch for dmesg(1) I use. You can enable timestamp > > conversion using -t and optionally specify a different output format > > using -f "fmt". > > > > If interested for inclusion in base, I could try to re-format it > > and come up with a manpage diff... > > ... > > So that's my feedback on the first round of patches. You should do a github > pull request https://github.com/freebsd/freebsd-src/pull/1985 Beware: I am a github noob :-). Currently it complains about Missing Signed-off-by lines (b346449) Real email address is needed (b346449) I've read CONTRIBUTING.md but I don't know where to put it. Apart from that, I hope that I addressed all items of your feedback (apart from char timebuf[64] as I don't know what would be a better size instead). If the goto approach is undesired, I need some recommendation. I personally have no problems with gotos as long as they are easy to follow and avoid endless nesting of if's of whatever. So any suggestions are welcome ;-). -Andrehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aXNepI5fqYoiNWt3>