Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Nov 2024 19:41:40 GMT
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 81f08f303805 - main - siftr: remove pointless assertion
Message-ID:  <202411141941.4AEJfeSe037182@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=81f08f303805bcfd0a32fb34835956740c3c9a81

commit 81f08f303805bcfd0a32fb34835956740c3c9a81
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2024-11-14 19:39:12 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-11-14 19:39:12 +0000

    siftr: remove pointless assertion
    
    The assertion is correct, but isn't useful.  Also it contradicts
    its own comment.
---
 sys/netinet/siftr.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/netinet/siftr.c b/sys/netinet/siftr.c
index ea1fbc8ff394..374b5595fcbc 100644
--- a/sys/netinet/siftr.c
+++ b/sys/netinet/siftr.c
@@ -597,9 +597,6 @@ siftr_findinpcb(int ipver, struct ip *ip, struct mbuf *m, uint16_t sport,
 {
 	struct inpcb *inp;
 
-	/* We need the tcbinfo lock. */
-	INP_INFO_WUNLOCK_ASSERT(&V_tcbinfo);
-
 	if (dir == PFIL_IN)
 		inp = (ipver == INP_IPV4 ?
 		    in_pcblookup(&V_tcbinfo, ip->ip_src, sport, ip->ip_dst,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202411141941.4AEJfeSe037182>