Date: Tue, 24 Nov 2015 13:20:25 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: marino@freebsd.org, Gerald Pfeifer <gerald@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r402352 - head/lang/gcc Message-ID: <20151124122024.GD76516@ivaldir.etoilebsd.net> In-Reply-To: <20151124115156.GA3457@FreeBSD.org> References: <201511241019.tAOAJMTF049917@repo.freebsd.org> <20151124110152.GA78748@FreeBSD.org> <5654459E.40100@marino.st> <20151124115156.GA3457@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--hoZxPH4CaxYzWscb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 24, 2015 at 11:51:56AM +0000, Alexey Dokuchaev wrote: > On Tue, Nov 24, 2015 at 12:10:22PM +0100, John Marino wrote: > > On 11/24/2015 12:01 PM, Alexey Dokuchaev wrote: > > > On Tue, Nov 24, 2015 at 10:19:22AM +0000, Gerald Pfeifer wrote: > > >> Author: gerald > > >> URL: https://svnweb.freebsd.org/changeset/ports/402352 > > >> > > >> [...] > > >> @@ -168,5 +168,10 @@ post-stage: > > >> fi > > >> .endfor > > >> cd ${WRKDIR} ; ${SED} -i -e "/PLIST.lib/ r PLIST.lib" ${TMPPLIST} > > >> + # This is the canonical GCC port, so add key commands without > > >> + # version numbers as part of their names. > > >=20 > > > Comment is badly indented (will be executed as part of the target rec= ipe). > >=20 > > Are you sure? I thought that only applies to legacy make, not bmake. >=20 > Hmm, indeed. >=20 > But even if bmake is smart enough to skip shell comments, it still looks > like part of the recipe, which is not very neat. >=20 And legacy make is still used on 9.x Bapt --hoZxPH4CaxYzWscb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlZUVggACgkQ8kTtMUmk6EzVwQCfQi2CHa7go3zmaTuLcs2tKzZR Og8AoLIQUhmKKU+Jtx0wC4vo73kW8tL1 =Zdid -----END PGP SIGNATURE----- --hoZxPH4CaxYzWscb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151124122024.GD76516>