Date: Fri, 25 Oct 2013 10:04:32 -0400 From: Sean Bruno <sean_bruno@yahoo.com> To: David Chisnall <theraven@FreeBSD.org> Cc: Matthew Fleming <mdf@FreeBSD.org>, "freebsd-current@freebsd.org" <freebsd-current@FreeBSD.org> Subject: Re: gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses Message-ID: <1382709872.2451.11.camel@localhost> In-Reply-To: <14061B35-A258-4368-BECD-9934CF594AE1@FreeBSD.org> References: <1382327452.2610.5.camel@localhost> <1382399026.7749.3.camel@localhost> <0744E30D-89EF-4340-A7DC-968AC27F302B@FreeBSD.org> <1382663626.2498.4.camel@localhost> <3656E3A3-F76E-42F4-BCFC-8B0F49FF5DA9@FreeBSD.org> <1382665803.2498.13.camel@localhost> <14061B35-A258-4368-BECD-9934CF594AE1@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-evJT1U4WoXKTpiFbhgIJ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Fri, 2013-10-25 at 06:38 -0400, David Chisnall wrote: > >=20 > > I'm simply trying to address the warnings that appear due to clang. > I > > find the builds very noisy and if there's a better way to address > this > > issue, I'm totally open to suggestions. >=20 > Well, for contrib code that isn't going to be around for much longer > like gperf, the best thing to do is probably just stick > -Wno-logical-op-parentheses in the CFLAGS. Alternatively, adding the > brackets as it suggested to indicate precedence is simple. >=20 > David=20 Agreed. Thank you for patience in dealing with me. :-) I will go with my original patch that simply puts parens where they can be picked up and leave the flow of the code alone. http://lists.freebsd.org/pipermail/freebsd-current/2013-October/045644.html sean --=-evJT1U4WoXKTpiFbhgIJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSanpvAAoJEBkJRdwI6BaH0ZIH/Ao6xX22bpMErll7DdbaZW3H gZ+NvxDRJVWjOnCJeMi9GS14J5Tf/usT/IciDiIBlqwy82hvZI+4pd7KTPCbYTwe mcN9A4q0Q4DhKUXvt8EbN5txWht5i7J+pDLdQP/kIaqmEgbcOM0FY6YJRytXJghC DXrgtvfb43Q6hWpUpN0R0mSwpNrmRi0i5Ck4BQt1p+yWlM2CqTrCDh1U/f8v1L+1 pyjNNRplAIpkQ1QdzCnPi2s4dIqQe+p1C3/9CPPdc1aFJSB9JENGXXofyDRjwjdG 2nfcTWKoq2hxlQZ/rsD4zHHnZMj5+vRs4Q0xr4IbawZ0s/hPZ7R7kg1SYT7d6Pg= =aVbv -----END PGP SIGNATURE----- --=-evJT1U4WoXKTpiFbhgIJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1382709872.2451.11.camel>