Date: Sat, 28 Feb 2026 07:50:21 +0100 From: Michael Tuexen <tuexen@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 454212b9718b - main - sctp: fix so_proto when peeling off a socket Message-ID: <F3588E0A-37E6-4273-94D4-7BC11BA14306@FreeBSD.org> In-Reply-To: <aaJIjSrqeYvXdOPg@cell.glebi.us> References: <699ef25d.42e41.7579887f@gitrepo.freebsd.org> <DA9B5022-602F-4720-9473-191B1A20B6B5@gmail.com> <BAFD25A7-7EE5-4B9C-9EFB-70B96F92AAD0@FreeBSD.org> <aaJIjSrqeYvXdOPg@cell.glebi.us>
index | next in thread | previous in thread | raw e-mail
> On 28. Feb 2026, at 02:44, Gleb Smirnoff <glebius@FreeBSD.org> wrote: > > On Fri, Feb 27, 2026 at 08:11:39AM +0100, Michael Tuexen wrote: > M> >> - so = sopeeloff(head); > M> >> + so = sopeeloff(head, &sctp_stream_protosw); > M> > > M> > This part of the change broke LINT-NOINET because sctp_stream_protosw is only defined in the INET case. I didn’t dig into the SCTP syscalls too far, but I think that the right protocol needs to be picked per the address family, right? > > btw, I tried to move the function to sctp_syscalls.c and this required exposing > soattach() and soalloc() outside. After weighting in and out decided to leave > it the way it is. I tried that also and came to the same conclusion. That is why I added the parameter to sopeeloff(). Best regards Michael > > -- > Gleb Smirnoffhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F3588E0A-37E6-4273-94D4-7BC11BA14306>