Date: Wed, 01 Jan 2020 20:54:16 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 242940] games/devilutionX 1.0.0: version update and fixed some issues Message-ID: <bug-242940-7788-CPoQpbrK3q@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-242940-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-242940-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242940 --- Comment #3 from Steve Wills <swills@FreeBSD.org> --- Thanks, overall this looks good. A few minor comments on the patch: LOCALBASE is where other ports/packages installed things, PREFIX is where *this* port/package is going to install things. I think CMAKE_INSTALL_SHARE= DIR should reference PREFIX. CMAKE_BUILD_TYPE is already set based on WITH_DEBUG, perhaps you just need = to duplicate the logic from here: https://svnweb.freebsd.org/ports/head/Mk/Uses/cmake.mk?revision=3D488341&vi= ew=3Dmarkup#l65 since I guess they don't use the standard build type names. Setting __BSD_VISIBLE and such is usually not advisable, instead it may be = that you need to specify the compiler standard. Also, hopefully you would be abl= e to use standard cmake flags instead of patching the CMakeLists.txt for that. (Checking CMAKE_SYSTEM_NAME does make sense tho, please keep that and send = it upstream.) Probably better to just remove the OS name from devilutionx.desktop entirel= y, it's not really required, people know what OS they're on. (And Dragonfly wouldn't have to re-patch it.) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242940-7788-CPoQpbrK3q>