Date: Thu, 24 May 2012 16:37:23 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: "David O'Brien" <obrien@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org> Subject: Re: svn commit: r235797 - head/contrib/gcc Message-ID: <20120524163545.T1094@besplex.bde.org> In-Reply-To: <20120523234154.GA22380@dragon.NUXI.org> References: <201205221818.q4MII7lk019626@svn.freebsd.org> <4FBCCED9.9050308@FreeBSD.org> <20120523234154.GA22380@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 May 2012, David O'Brien wrote: > On Wed, May 23, 2012 at 01:49:45PM +0200, Dimitry Andric wrote: >> On 2012-05-22 20:18, David E. O'Brien wrote: >>> Log: >>> Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit platforms. > ... >> Until all the additional warnings this causes have been fixed, can this >> commit please be reverted for now? > > Yes. I cannot believe we've been abusing "%q" this badly. Using it at all is using it badly, so your change should have had no effect. But when it was used to print quad_t's, its use was almost reasonable, and the change broke that too. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120524163545.T1094>