Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Jul 2022 19:14:21 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 02a226ac342f - main - Suppress possible unused variable warning for icl_soft.c
Message-ID:  <202207271914.26RJELVG058172@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by dim:

URL: https://cgit.FreeBSD.org/src/commit/?id=02a226ac342f0fb622e654e461c41f4f588f4186

commit 02a226ac342f0fb622e654e461c41f4f588f4186
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-27 19:00:22 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-27 19:13:58 +0000

    Suppress possible unused variable warning for icl_soft.c
    
    With clang 15, the following -Werror warning is produced on i386:
    
        sys/dev/iscsi//icl_soft.c:1277:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
                int i;
                    ^
    
    The 'i' variable is used later in the icl_soft_conn_pdu_get_bio()
    function, via the PHYS_TO_DMAP() macro. However, on i386 and some other
    architectures, this macro is defined to panic immediately, so in those
    cases, 'i' is indeed not used. Suppress the warning by marking 'i' as
    unused.
    
    MFC after:      3 days
---
 sys/dev/iscsi/icl_soft.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/iscsi/icl_soft.c b/sys/dev/iscsi/icl_soft.c
index 700f1c6e79f8..8a1002e7e4a0 100644
--- a/sys/dev/iscsi/icl_soft.c
+++ b/sys/dev/iscsi/icl_soft.c
@@ -1274,7 +1274,7 @@ icl_soft_conn_pdu_get_bio(struct icl_conn *ic, struct icl_pdu *ip,
 {
 	vm_offset_t vaddr;
 	size_t page_offset, todo;
-	int i;
+	int i __unused;
 
 	MPASS(bp->bio_flags & BIO_UNMAPPED);
 	if (bio_off < PAGE_SIZE - bp->bio_ma_offset) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207271914.26RJELVG058172>