Date: Thu, 10 Apr 2014 21:30:01 GMT From: Marius Strobl <marius@freebsd.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/186891: [puc] [patch] MCS9922 based card not known Message-ID: <201404102130.s3ALU10g036643@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/186891; it has been noted by GNATS.
From: Marius Strobl <marius@freebsd.org>
To: bug-followup@FreeBSD.org, bsd@dino.sk
Cc:
Subject: Re: kern/186891: [puc] [patch] MCS9922 based card not known
Date: Thu, 10 Apr 2014 23:26:56 +0200
--0rSojgWGcpz+ezC3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
The submitted patch seems inherently bogus; the referenced function
puc_config_saturn() doesn't exist/isn't provided and it's always a bad
idea to add an entry for a device that potentially is part of a line
of controllers with different port configurations and all having the
same vendor and device ID combination as a wildcard match to puc(4).
However, most importantly, MCS9922 apparently are multi-function
devices providing one UART per function so puc(4) shouldn't be used
in the first place but uart(4) should be tought to probe and attach
these controllers directly instead. Could you please revert your
patch for puc(4) and test whether the attached one provies you with
two instances of uart(4) for that card?
Marius
--0rSojgWGcpz+ezC3
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="uart_mc9904.diff"
Index: uart_bus_pci.c
===================================================================
--- uart_bus_pci.c (revision 264257)
+++ uart_bus_pci.c (working copy)
@@ -135,6 +135,8 @@
"MosChip MCS9901 PCIe to Peripheral Controller", 0x10 },
{ 0x9710, 0x9904, 0xa000, 0x1000,
"MosChip MCS9904 PCIe to Peripheral Controller", 0x10 },
+{ 0x9710, 0x9922, 0x0000, 0x0000,
+ "MosChip MCS9922 PCIe to Peripheral Controller", 0x10 },
{ 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0x10 },
{ 0xffff, 0, 0xffff, 0, NULL, 0, 0}
};
--0rSojgWGcpz+ezC3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404102130.s3ALU10g036643>