Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Sep 2021 18:11:56 +0100
From:      Andrew Turner <andrew@fubar.geek.nz>
To:        Ronald Klop <ronald-lists@klop.ws>
Cc:        Andrew Turner <andrew@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: fd860ace3bde - main - Remove the DN flag from the initial arm64 fpcr value
Message-ID:  <7E354DA3-CC3D-4240-A4EF-320AD7728C59@fubar.geek.nz>
In-Reply-To: <629177790.2.1631626955525@mailrelay>
References:  <202109141253.18ECrVoR016500@gitrepo.freebsd.org> <629177790.2.1631626955525@mailrelay>

index | next in thread | previous in thread | raw e-mail

I found it with the lldb test suite. I also checked the value Mac and Linux initialised the register to & found it to be zero.

Andrew

> On 14 Sep 2021, at 14:42, Ronald Klop <ronald-lists@klop.ws> wrote:
> 
> Hi,
> 
> Do you have an example of this software? Just for my understanding.
> 
> Ronald.
> 
> Van: Andrew Turner <andrew@FreeBSD.org>
> Datum: dinsdag, 14 september 2021 14:53
> Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
> Onderwerp: git: fd860ace3bde - main - Remove the DN flag from the initial arm64 fpcr value
> 
> The branch main has been updated by andrew:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=fd860ace3bded96bee0e5c090a5a4d8b085b700c <https://cgit.freebsd.org/src/commit/?id=fd860ace3bded96bee0e5c090a5a4d8b085b700c>;
> 
> commit fd860ace3bded96bee0e5c090a5a4d8b085b700c
> Author:     Andrew Turner <andrew@FreeBSD.org>
> AuthorDate: 2021-08-25 10:05:55 +0000
> Commit:     Andrew Turner <andrew@FreeBSD.org>
> CommitDate: 2021-09-14 12:52:48 +0000
> 
>     Remove the DN flag from the initial arm64 fpcr value
>     
>     This fixes software that expects NaN values to propagate.
>     
>     Sponsored by:   The FreeBSD Foundation
> ---
>  sys/arm64/include/vfp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/arm64/include/vfp.h b/sys/arm64/include/vfp.h
> index 629b1b7fadf4..bee0121d9d2a 100644
> --- a/sys/arm64/include/vfp.h
> +++ b/sys/arm64/include/vfp.h
> @@ -35,7 +35,7 @@
>  #define    VFPCR_AHP       (0x04000000)    /* alt. half-precision: */
>  #define    VFPCR_DN        (0x02000000)    /* default NaN enable */
>  #define    VFPCR_FZ        (0x01000000)    /* flush to zero enabled */
> -#define    VFPCR_INIT      VFPCR_DN    /* Default fpcr after exec */
> +#define    VFPCR_INIT      0       /* Default fpcr after exec */
>  
>  #define    VFPCR_RMODE_OFF     22      /* rounding mode offset */
>  #define    VFPCR_RMODE_MASK    (0x00c00000)    /* rounding mode mask */
> _______________________________________________
> dev-commits-src-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>;
> To unsubscribe, send any mail to "dev-commits-src-all-unsubscribe@freebsd.org"



help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7E354DA3-CC3D-4240-A4EF-320AD7728C59>