Date: Tue, 04 Aug 2026 17:20:17 +0200 From: "Herbert J. Skuhra" <herbert@gojira.at> To: Alan Somers <asomers@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati <bhatijitendra2022@gmail.com> Subject: Re: git: 4bd01d6ae016 - main - fts: refactor to use fd-relative operations internally Message-ID: <878q6lzzda.wl-herbert@gojira.at> In-Reply-To: <CAOtMX2h9-n9Afp1-DcZOw4zQ6MsWkYAByEtKdrV7xOfv7-f58g@mail.gmail.com> References: <6a70e844.251cb.6995429f@gitrepo.freebsd.org> <87bjbiysvw.wl-herbert@gojira.at> <CAOtMX2h9-n9Afp1-DcZOw4zQ6MsWkYAByEtKdrV7xOfv7-f58g@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Tue, 04 Aug 2026 16:20:59 +0200, Alan Somers wrote: > > On Tue, Aug 4, 2026 at 6:25 AM Herbert J. Skuhra <herbert@gojira.at> wrote: > > > > On Mon, 03 Aug 2026 21:13:08 +0200, Alan Somers wrote: > > > > > > The branch main has been updated by asomers: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4bd01d6ae01632501b63438b8d9a401db9744a78 > > > > > > commit 4bd01d6ae01632501b63438b8d9a401db9744a78 > > > Author: Jitendra Bhati <bhatijitendra2022@gmail.com> > > > AuthorDate: 2026-06-12 17:07:55 +0000 > > > Commit: Alan Somers <asomers@FreeBSD.org> > > > CommitDate: 2026-08-03 19:12:28 +0000 > > > > > > fts: refactor to use fd-relative operations internally > > > > > > Replace all _open() calls with _openat() in __fts_open(), fts_read(), > > > and fts_children(). Replace statfs() with _fstatfs(). > > > > > > Add fts_dirfd to struct _ftsent, set to the file descriptor of the > > > parent directory. Callers can use openat(ent->fts_dirfd, ent->fts_name, > > > ...) to access files safely without relying on fts_accpath, which > > > enables programs in capability mode to open the files described by > > > _ftsent. > > > > > > This is a preparatory change for fts_openat() which will allow callers > > > to provide a pre-opened directory fd, enabling fts(3) traversal inside > > > Capsicum capability mode. > > > > > > Mirror all fts_open() changes to fts_open_b(). > > > > > > As a result of expanding _ftsend, publish new ELF symbol versions for > > > fts_openat and related functions. > > > > > > Sponsored by: Google LLC (GSoC 2026) > > > Reviewed by: asomers > > > Pull Request: https://github.com/freebsd/freebsd-src/pull/2303 > > > --- > > > include/fts.h | 2 + > > > lib/libc/gen/Makefile.inc | 1 + > > > lib/libc/gen/Symbol.map | 18 +- > > > lib/libc/gen/fts-compat15.c | 1355 +++++++++++++++++++++++++++++++++++++++++++ > > > lib/libc/gen/fts-compat15.h | 97 ++++ > > > lib/libc/gen/fts.3 | 18 +- > > > lib/libc/gen/fts.c | 49 +- > > > 7 files changed, 1519 insertions(+), 21 deletions(-) > > > > This change seems to break poudriere: > > > > [00:00:04] Recording filesystem state for prepkg...mtree: ./bin: No such file or directory > > [ERROR] Unhandled error! > > [00:00:04] Cleaning up > > [00:00:04] Unmounting file systems > > Exiting with status 1 > > > > -- > > Herbert > > How so? Can you supply more complete steps to reproduce the problem? After updating to main-n287945-495826f69d96 this morning 'poudriere testport -j main dns/unbound' fails. $ poudriere jail -l JAILNAME VERSION ARCH METHOD TIMESTAMP PATH main 16.0-CURRENT amd64 pkgbase 2026-08-04 15:28:15 /usr/local/poudriere/jails/main Rebuilding poudriere does not help. Reverting 4bd01d6ae01632501b63438b8d9a401db9744a78 resolves the issue, but I had to rebuild poudriere again.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?878q6lzzda.wl-herbert>