Date: Tue, 14 Feb 2023 14:05:28 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: =?utf-8?Q?Stefan_E=C3=9Fer?= <se@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: c2bb66023fe3 - main - kbdcontrol: enable pre-Unicode dead key table compatibility Message-ID: <B7AB527B-52E0-4590-9166-04092249AD84@freebsd.org> In-Reply-To: <202302141315.31EDFu9Q044384@gitrepo.freebsd.org> References: <202302141315.31EDFu9Q044384@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 Feb 2023, at 13:15, Stefan E=C3=9Fer <se@FreeBSD.org> wrote: >=20 > The branch main has been updated by se: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc2bb66023fe3e3617f56302b6960f595= 45a5535c >=20 > commit c2bb66023fe3e3617f56302b6960f59545a5535c > Author: Stefan E=C3=9Fer <se@FreeBSD.org> > AuthorDate: 2023-02-14 12:49:06 +0000 > Commit: Stefan E=C3=9Fer <se@FreeBSD.org> > CommitDate: 2023-02-14 12:49:06 +0000 >=20 > kbdcontrol: enable pre-Unicode dead key table compatibility >=20 > The definition of pre-Unicode keymap ioctls will be made optional = and > dependent on COMPAT_FREEBSD13 in a follow-up commit to 14-CURRENT. >=20 > While we generally provide ABI compatibility for older binaries on > a new kernel, but not functionally extended userland programs on an > old kernel, it has been specifically requested to preserve ABI > compatibility for the kbdcontrol program for both these cases. >=20 > Passing the kernel configuration option COMPAT_FREEBSD13 to the = build > of kbdcontrol will make ioctls visible to the build that are = normally > hidden, but required to implement compatibility with kernels that = only > support 8 bit characters in dead key maps. >=20 > This commit is not to be merged to any previous FreeBSD version and > it shall be reverted as soon as this type of ABI compatibility is = no > longer deemed necessary (probably before 14-STABLE is branched). >=20 > This commit is a part of review D38465 and split off to allow it to = be > reverted using the commit ID. > --- > usr.sbin/kbdcontrol/Makefile | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/usr.sbin/kbdcontrol/Makefile = b/usr.sbin/kbdcontrol/Makefile > index 960671a40fe7..d2107fb86290 100644 > --- a/usr.sbin/kbdcontrol/Makefile > +++ b/usr.sbin/kbdcontrol/Makefile > @@ -9,4 +9,7 @@ SRCS=3D kbdcontrol.c lex.l > WARNS?=3D 4 > CFLAGS+=3D -I${.CURDIR} >=20 > +# temporarily added for pre-Unicode accent key API/ABI compatibility > +CFLAGS+=3D -DCOMPAT_FREEBSD13 This doesn=E2=80=99t seem right... COMPAT_FREEBSD* is for kernel not = userspace. Normally this would be a _WANT_FOO. Jess > + > .include <bsd.prog.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B7AB527B-52E0-4590-9166-04092249AD84>