Date: Sat, 10 Apr 2021 04:33:37 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 06d8a116bd6b - main - libc: add _get_tp() private function Message-ID: <YHEAcfHTO60CuN7f@kib.kiev.ua> In-Reply-To: <4BDA2D21-D5D0-4EC2-B6F7-B99260D046E0@freebsd.org> References: <202104092047.139KlBo3071549@gitrepo.freebsd.org> <4BDA2D21-D5D0-4EC2-B6F7-B99260D046E0@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 09, 2021 at 09:57:55PM +0100, Jessica Clarke wrote: > On 9 Apr 2021, at 21:47, Konstantin Belousov <kib@FreeBSD.org> wrote: > > > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac > > > > commit 06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac > > Author: Konstantin Belousov <kib@FreeBSD.org> > > AuthorDate: 2021-04-05 03:30:35 +0000 > > Commit: Konstantin Belousov <kib@FreeBSD.org> > > CommitDate: 2021-04-09 20:46:24 +0000 > > > > libc: add _get_tp() private function > > > > which returns pointer to tcb > > This feels like it should be static inline in a header. Also we already have > _tcb_get in pthread_md.h that should be entirely equivalent, and > _libc_get_static_tls_base that’s basically the same again but with an optional > offset. Can we do something to unify all the inline asm into one place per > architecture rather than growing yet more copies of the same thing? Yes, this should happens, eventually.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YHEAcfHTO60CuN7f>