Date: Wed, 19 Aug 2015 21:08:43 +0000 (UTC) From: "Alexander V. Chernikov" <melifaro@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r286945 - head/sys/netinet Message-ID: <201508192108.t7JL8hvS041932@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: melifaro Date: Wed Aug 19 21:08:42 2015 New Revision: 286945 URL: https://svnweb.freebsd.org/changeset/base/286945 Log: Check value return from lle_create() for NULL. This bug sneaked unnoticed in r286722. Reported by: adrian Modified: head/sys/netinet/if_ether.c Modified: head/sys/netinet/if_ether.c ============================================================================== --- head/sys/netinet/if_ether.c Wed Aug 19 21:04:50 2015 (r286944) +++ head/sys/netinet/if_ether.c Wed Aug 19 21:08:42 2015 (r286945) @@ -790,10 +790,13 @@ match: */ IF_AFDATA_WLOCK(ifp); la = lla_create(LLTABLE(ifp), 0, (struct sockaddr *)&sin); - arp_update_lle(ah, ifp, la); + if (la != NULL) + arp_update_lle(ah, ifp, la); IF_AFDATA_WUNLOCK(ifp); - arp_mark_lle_reachable(la); - LLE_WUNLOCK(la); + if (la != NULL) { + arp_mark_lle_reachable(la); + LLE_WUNLOCK(la); + } } reply: if (op != ARPOP_REQUEST)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201508192108.t7JL8hvS041932>