Date: Wed, 14 Aug 2013 09:11:50 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Pedro F. Giffuni <pfg@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r254286 - head/sys/fs/ext2fs Message-ID: <9B5BBD34-F953-40BF-8C10-0EF466ED3350@FreeBSD.org> In-Reply-To: <201308131839.r7DIdaLD037277@svn.freebsd.org> References: <201308131839.r7DIdaLD037277@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 13, 2013, at 20:39, Pedro F. Giffuni <pfg@FreeBSD.org> wrote: > Author: pfg > Date: Tue Aug 13 18:39:36 2013 > New Revision: 254286 > URL: http://svnweb.freebsd.org/changeset/base/254286 >=20 > Log: > ext2fs: update format specifiers for ext4 type. >=20 > Reported by: Sam Fourman Jr. > MFC after: 3 weeks >=20 > Modified: > head/sys/fs/ext2fs/ext2_subr.c >=20 > Modified: head/sys/fs/ext2fs/ext2_subr.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/fs/ext2fs/ext2_subr.c Tue Aug 13 18:14:53 2013 = (r254285) > +++ head/sys/fs/ext2fs/ext2_subr.c Tue Aug 13 18:39:36 2013 = (r254286) > @@ -150,7 +150,7 @@ ext2_checkoverlap(struct buf *bp, struct > ep->b_blkno + btodb(ep->b_bcount) <=3D start) > continue; > vprint("Disk overlap", vp); > - (void)printf("\tstart %d, end %d overlap start %lld, end = %ld\n", > + (void)printf("\tstart %ld, end %ld overlap start %lld, = end %ld\n", > start, last, (long long)ep->b_blkno, > (long)(ep->b_blkno + btodb(ep->b_bcount) - 1)); > panic("Disk buffer overlap"); This still fails on arches where int64_t is aliased to long long (basically, the 32-bit arches). Since using PRId64 is apparently frowned upon, the easiest solution is to cast the 'start' and 'last' variables to long long, and print them using %lld. -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9B5BBD34-F953-40BF-8C10-0EF466ED3350>