Date: Fri, 1 Dec 2006 02:30:12 GMT From: "Kobayashi Shun-ichi" <koba@mbox.kudpc.kyoto-u.ac.jp> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/106104: [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300 Message-ID: <200612010230.kB12UCs2073235@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/106104; it has been noted by GNATS. From: "Kobayashi Shun-ichi" <koba@mbox.kudpc.kyoto-u.ac.jp> To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/106104: [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300 Date: Fri, 1 Dec 2006 11:20:07 +0900 ------=_Part_21237_4533916.1164939607095 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline >Number: 106104 >Category: kern >Synopsis: [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300 >Severity: serious >Priority: medium >Responsible: freebsd-bugs@FreeBSD.org >State: open >Class: sw-bug >Arrival-Date: Fri Dec 01 01:50:14 GMT 2006 >Closed-Date: >Last-Modified: never >Originator: Shun-ichi Kobayashi >Release: FreeBSD 6.2-PRERELEASE i386 >Description: It is already known that some machines that uses ich(4) sound driver must turn on inverted external amplifier sense flag individually. See: Rev. 1.57 and Rev. 1.58 (I also referred an email entitled "kern/94056:[PATCH] ..." in freebsd-bugs ML) My machine HP Compaq nx 4300 also requires this. [machine] HP Compaq nx 4300 [pciconf -vl] pcm0@pci0:30:2: class=0x040100 card=0x309a103c chip=0x266e8086 rev=0x04 hdr=0x00 vendor = 'Intel Corporation' device = '82801FB/FR/FW/FRW AC '97 Audio Controller' class = multimedia subclass = audio >How-To-Repeat: >Fix: I attached a simple patch file for this bug to this email. Original file is /usr/src/sys/dev/sound/pci/ich.c,v 1.53.2.8 2006/08/22 02:37:03 Attached patch file is named as ich.c.diff (created by diff -c) Here is a copied and pasted version for your reference. *** /usr/src/sys/dev/sound/pci/ich.c.orig Tue Nov 28 18:48:52 2006 --- /usr/src/sys/dev/sound/pci/ich.c Fri Dec 1 10:41:07 2006 *************** *** 851,856 **** --- 851,857 ---- case 0x81c0104d: /* Sony VAIO type T */ case 0x81c5104d: /* Sony VAIO VGN B1VP/B1XP */ case 0x3089103c: /* Compaq Presario B3800 */ + case 0x309a103c: /* HP Compaq nx4300 */ ac97_setflags(sc->codec, ac97_getflags(sc->codec) | AC97_F_EAPD_INV); break; default: ------=_Part_21237_4533916.1164939607095 Content-Type: application/octet-stream; name=ich.c.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_ev5ysf5c Content-Disposition: attachment; filename="ich.c.diff" KioqIC91c3Ivc3JjL3N5cy9kZXYvc291bmQvcGNpL2ljaC5jLm9yaWcJVHVlIE5vdiAyOCAxODo0 ODo1MiAyMDA2Ci0tLSAvdXNyL3NyYy9zeXMvZGV2L3NvdW5kL3BjaS9pY2guYwlGcmkgRGVjICAx IDEwOjQxOjA3IDIwMDYKKioqKioqKioqKioqKioqCioqKiA4NTEsODU2ICoqKioKLS0tIDg1MSw4 NTcgLS0tLQogIAljYXNlIDB4ODFjMDEwNGQ6CS8qIFNvbnkgVkFJTyB0eXBlIFQgKi8KICAJY2Fz ZSAweDgxYzUxMDRkOgkvKiBTb255IFZBSU8gVkdOIEIxVlAvQjFYUCAqLwogIAljYXNlIDB4MzA4 OTEwM2M6CS8qIENvbXBhcSBQcmVzYXJpbyBCMzgwMCAqLworICAgICAgICAgY2FzZSAweDMwOWEx MDNjOiAgICAgICAgLyogSFAgQ29tcGFxIG54NDMwMCAqLwogIAkJYWM5N19zZXRmbGFncyhzYy0+ Y29kZWMsIGFjOTdfZ2V0ZmxhZ3Moc2MtPmNvZGVjKSB8IEFDOTdfRl9FQVBEX0lOVik7CiAgCQli cmVhazsKICAJZGVmYXVsdDoK ------=_Part_21237_4533916.1164939607095--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612010230.kB12UCs2073235>