Date: 09 Apr 2001 16:09:11 +0200 From: Matthias Andree <ma@dt.e-technik.uni-dortmund.de> To: freebsd-stable@freebsd.org Subject: BDECFLAGS break current 4.x-stable build Message-ID: <m34rvyi2rc.fsf@emma1.emma.line.org>
next in thread | raw e-mail | index | archive | help
4.x-stable Checked out today (2001-04-09) at 13:00 UTC
*****
NOTE: _ALL_ problems mentioned below disappear with BDECFLAGS removed
from CFLAGS, thus a default build will not encounter these.
*****
I caught some hard errors (build aborted) with CFLAGS+=${BDECFLAGS} in
/etc/make.conf:
/usr/src/secure/lib/libcrypt/crypt-des.c:196: syntax error before `int'
(it doesn't understand "INLINE" here with BDECFLAGS enabled)
Same problem for: (one problem shown as example)
/usr/src/lib/libncurses/../../contrib/ncurses/ncurses/tinfo/comp_error.c:71:
syntax error before `int'
(it doesn't understand "inline" here with BDECFLAGS enabled)
and various other places in libncurses
libskey with BDECFLAGS: (one problem shown as example)
/usr/src/lib/libskey/skey.h:43: warning: prototype declaration
cc1: warnings being treated as errors
/usr/src/lib/libskey/skeylogin.c: In function `skeylookup':
/usr/src/lib/libskey/skeylogin.c:115: warning: passing arg 1 of `umask' with different width due to prototype
/usr/src/lib/libskey/skeylogin.c:117: warning: passing arg 1 of `umask' with different width due to prototype
*** Error code 1
libc/gen/arc4random.c:
/usr/src/lib/libc/../libc/gen/arc4random.c: At top level:
/usr/src/lib/libc/../libc/gen/arc4random.c:98: syntax error before `u_int8_t'
/usr/src/lib/libc/../libc/gen/arc4random.c:100: warning: function declaration isn't a prototype
/usr/src/lib/libc/../libc/gen/arc4random.c:113: syntax error before `u_int32_t'
/usr/src/lib/libc/../libc/gen/arc4random.c:115: warning: function declaration isn't a prototype
Removing the BDECFLAGS from CFLAGS in make.conf fixes the build (and
gets me rid of tons of warnings). I'm not sure what causes this.
I'm not investigating this further since I'm short on time and it might
be worth fixing after 4.3 only.
BDECFLAGS are from 4.3-RC's /etc/defaults/make.conf (see below)
Context:
------------------------------------------------------------------------------
static u_char ascii64[] =
"./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
/* 0000000000111111111122222222223333333333444444444455555555556666 */
/* 0123456789012345678901234567890123456789012345678901234567890123 */
static INLINE int
ascii_to_bin(char ch)
{
if (ch > 'z')
return(0);
if (ch >= 'a')
return(ch - 'a' + 38);
------------------------------------------------------------------------------
My current BDECFLAGS:
------------------------------------------------------------------------------
BDECFLAGS= -W -Wall -ansi -pedantic -Wbad-function-cast -Wcast-align \
-Wcast-qual -Wchar-subscripts -Wconversion -Winline \
-Wmissing-prototypes -Wnested-externs -Wpointer-arith \
-Wredundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings
------------------------------------------------------------------------------
--
Matthias Andree
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?m34rvyi2rc.fsf>