Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Oct 2014 13:22:33 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r273132 - head/sys/fs/deadfs
Message-ID:  <201410151322.s9FDMXSf041562@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Oct 15 13:22:33 2014
New Revision: 273132
URL: https://svnweb.freebsd.org/changeset/base/273132

Log:
  Style changes for deadfs:
  - ANSIfy VOPs.
  - Remove trivial comments.
  - Remove ARGSUSED.
  - Remove copies of the vop_XXX_args structure definitions in comments.
  
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/fs/deadfs/dead_vnops.c

Modified: head/sys/fs/deadfs/dead_vnops.c
==============================================================================
--- head/sys/fs/deadfs/dead_vnops.c	Wed Oct 15 13:16:51 2014	(r273131)
+++ head/sys/fs/deadfs/dead_vnops.c	Wed Oct 15 13:22:33 2014	(r273132)
@@ -77,14 +77,10 @@ struct vop_vector dead_vnodeops = {
 	.vop_write =		dead_write,
 };
 
-/* ARGSUSED */
 static int
-dead_getwritemount(ap)
-	struct vop_getwritemount_args /* {
-		struct vnode *a_vp;
-		struct mount **a_mpp;
-	} */ *ap;
+dead_getwritemount(struct vop_getwritemount_args *ap)
 {
+
 	*(ap->a_mpp) = NULL;
 	return (0);
 }
@@ -92,14 +88,8 @@ dead_getwritemount(ap)
 /*
  * Trivial lookup routine that always fails.
  */
-/* ARGSUSED */
 static int
-dead_lookup(ap)
-	struct vop_lookup_args /* {
-		struct vnode * a_dvp;
-		struct vnode ** a_vpp;
-		struct componentname * a_cnp;
-	} */ *ap;
+dead_lookup(struct vop_lookup_args *ap)
 {
 
 	*ap->a_vpp = NULL;
@@ -109,33 +99,17 @@ dead_lookup(ap)
 /*
  * Open always fails as if device did not exist.
  */
-/* ARGSUSED */
 static int
-dead_open(ap)
-	struct vop_open_args /* {
-		struct vnode *a_vp;
-		int  a_mode;
-		struct ucred *a_cred;
-		struct proc *a_p;
-	} */ *ap;
+dead_open(struct vop_open_args *ap)
 {
 
 	return (ENXIO);
 }
 
-/*
- * Vnode op for read
- */
-/* ARGSUSED */
 int
-dead_read(ap)
-	struct vop_read_args /* {
-		struct vnode *a_vp;
-		struct uio *a_uio;
-		int  a_ioflag;
-		struct ucred *a_cred;
-	} */ *ap;
+dead_read(struct vop_read_args *ap)
 {
+
 	/*
 	 * Return EOF for tty devices, EIO for others
 	 */
@@ -144,25 +118,15 @@ dead_read(ap)
 	return (0);
 }
 
-/*
- * Vnode op for write
- */
-/* ARGSUSED */
 int
-dead_write(ap)
-	struct vop_write_args /* {
-		struct vnode *a_vp;
-		struct uio *a_uio;
-		int  a_ioflag;
-		struct ucred *a_cred;
-	} */ *ap;
+dead_write(struct vop_write_args *ap)
 {
+
 	return (EIO);
 }
 
 int
-dead_poll(ap)
-	struct vop_poll_args *ap;
+dead_poll(struct vop_poll_args *ap)
 {
 
 	if (ap->a_events & ~POLLSTANDARD)
@@ -176,15 +140,7 @@ dead_poll(ap)
 }
 
 static int
-dead_rename(ap)
-	struct vop_rename_args  /* {
-		struct vnode *a_fdvp;
-		struct vnode *a_fvp;
-		struct componentname *a_fcnp;
-		struct vnode *a_tdvp;
-		struct vnode *a_tvp;
-		struct componentname *a_tcnp;
-	} */ *ap;
+dead_rename(struct vop_rename_args *ap)
 {
 
 	vop_rename_fail(ap);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201410151322.s9FDMXSf041562>