Date: Thu, 28 Jul 2022 14:04:29 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: e2fa10e67646 - main - style: Tighten up one use of 'may' Message-ID: <202207281404.26SE4ThH088960@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=e2fa10e67646fc754fa352b56ceb38d1ff4cdb5e commit e2fa10e67646fc754fa352b56ceb38d1ff4cdb5e Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2022-07-28 14:01:09 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2022-07-28 14:01:54 +0000 style: Tighten up one use of 'may' Declarations of variables must be placed before the statements of a block, by convention. Use 'must' instead of 'may' here and clarify langauge. Sponsored by: Netflix Reviewed by: pstef, rpokala, hselasky Differential Revision: https://reviews.freebsd.org/D35959 --- share/man/man9/style.9 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/share/man/man9/style.9 b/share/man/man9/style.9 index 4ef0c0a8b4bb..64fcc7425b4e 100644 --- a/share/man/man9/style.9 +++ b/share/man/man9/style.9 @@ -701,8 +701,7 @@ then in alphabetical order; multiple ones per line are okay. If a line overflows reuse the type keyword. Variables may be initialized where declared especially when they are constant for the rest of the scope. -Declarations may be placed before executable lines at the start -of any block. +Declarations may be in any block, but must be placed before statements. Calls to complicated functions should be avoided when initializing variables. .Bd -literal struct foo one, *two;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207281404.26SE4ThH088960>