Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 9 Jul 2016 11:58:59 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r302494 - in head/sys/dev/ntb: . if_ntb
Message-ID:  <201607091158.u69BwxB8098368@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: mav
Date: Sat Jul  9 11:58:59 2016
New Revision: 302494
URL: https://svnweb.freebsd.org/changeset/base/302494

Log:
  Synchronize MTU code with Linux.
  
  It is mandatory for transport compatibility.

Modified:
  head/sys/dev/ntb/if_ntb/if_ntb.c
  head/sys/dev/ntb/ntb_transport.c

Modified: head/sys/dev/ntb/if_ntb/if_ntb.c
==============================================================================
--- head/sys/dev/ntb/if_ntb/if_ntb.c	Sat Jul  9 11:57:21 2016	(r302493)
+++ head/sys/dev/ntb/if_ntb/if_ntb.c	Sat Jul  9 11:58:59 2016	(r302494)
@@ -125,8 +125,7 @@ ntb_net_attach(device_t dev)
 	ether_ifattach(ifp, sc->eaddr);
 	ifp->if_capabilities = IFCAP_HWCSUM | IFCAP_JUMBO_MTU;
 	ifp->if_capenable = ifp->if_capabilities;
-	ifp->if_mtu = ntb_transport_max_size(sc->qp) - ETHER_HDR_LEN -
-	    ETHER_CRC_LEN;
+	ifp->if_mtu = ntb_transport_max_size(sc->qp) - ETHER_HDR_LEN;
 
 	ntb_transport_link_up(sc->qp);
 	return (0);
@@ -177,7 +176,7 @@ ntb_ioctl(struct ifnet *ifp, u_long comm
 	case SIOCSIFMTU:
 	    {
 		if (ifr->ifr_mtu > ntb_transport_max_size(sc->qp) -
-		    ETHER_HDR_LEN - ETHER_CRC_LEN) {
+		    ETHER_HDR_LEN) {
 			error = EINVAL;
 			break;
 		}

Modified: head/sys/dev/ntb/ntb_transport.c
==============================================================================
--- head/sys/dev/ntb/ntb_transport.c	Sat Jul  9 11:57:21 2016	(r302493)
+++ head/sys/dev/ntb/ntb_transport.c	Sat Jul  9 11:58:59 2016	(r302494)
@@ -489,8 +489,7 @@ ntb_transport_init_queue(struct ntb_tran
 	qp->rx_info = (void *)(qp->tx_mw + tx_size);
 
 	/* Due to house-keeping, there must be at least 2 buffs */
-	qp->tx_max_frame = qmin(tx_size / 2,
-	    transport_mtu + sizeof(struct ntb_payload_header));
+	qp->tx_max_frame = qmin(transport_mtu, tx_size / 2);
 	qp->tx_max_entry = tx_size / qp->tx_max_frame;
 
 	callout_init(&qp->link_work, 0);
@@ -1170,8 +1169,7 @@ ntb_transport_setup_qp_mw(struct ntb_tra
 	qp->remote_rx_info = (void*)(qp->rx_buff + rx_size);
 
 	/* Due to house-keeping, there must be at least 2 buffs */
-	qp->rx_max_frame = qmin(rx_size / 2,
-	    transport_mtu + sizeof(struct ntb_payload_header));
+	qp->rx_max_frame = qmin(transport_mtu, rx_size / 2);
 	qp->rx_max_entry = rx_size / qp->rx_max_frame;
 	qp->rx_index = 0;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607091158.u69BwxB8098368>