Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 30 Oct 2003 13:32:45 -0800
From:      Lars Eggert <larse@ISI.EDU>
To:        Soren Schmidt <sos@spider.deepcore.dk>
Cc:        freebsd-current@FreeBSD.ORG
Subject:   Re: ATAng regression: cdcontrol close not working
Message-ID:  <3FA1837D.4040300@isi.edu>
In-Reply-To: <200310302048.h9UKmHaB021300@spider.deepcore.dk>
References:  <200310302048.h9UKmHaB021300@spider.deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help 

[-- Attachment #1 --]
Soren Schmidt wrote:
> 
> Anyhow if you loose the test for error in atapi-cd.c::acd_tray in the
> close case, does it work then ?

If you mean as below, no, that didn't help:

Index: atapi-cd.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/atapi-cd.c,v
retrieving revision 1.149
diff -u -r1.149 atapi-cd.c
--- atapi-cd.c  18 Oct 2003 17:24:51 -0000      1.149
+++ atapi-cd.c  30 Oct 2003 21:31:23 -0000
@@ -1884,11 +1884,10 @@

      if (cdp->cap.mechanism & MST_EJECT) {
         if (close) {
-           if (!(error = acd_start_stop(cdp, 3))) {
-               acd_read_toc(cdp);
-               acd_prevent_allow(cdp, 1);
-               cdp->flags |= F_LOCKED;
-           }
+            error = acd_start_stop(cdp, 3);
+           acd_read_toc(cdp);
+           acd_prevent_allow(cdp, 1);
+           cdp->flags |= F_LOCKED;
         }
         else {
             acd_start_stop(cdp, 0);

Lars
-- 
Lars Eggert <larse@isi.edu>           USC Information Sciences Institute

[-- Attachment #2 --]
0	*H
010	+0	*H
	080fErtcvE.0
	*H
010	UZA10UWestern Cape10U	Cape Town10U
Thawte Consulting1(0&UCertification Services Division1$0"UThawte Personal Freemail CA1+0)	*H
	personal-freemail@thawte.com0
000830000000Z
040827235959Z010	UZA10UWestern Cape10U	Cape Town10
U
Thawte10UCertificate Services1(0&UPersonal Freemail RSA 2000.8.3000
	*H
032c	%E>nx'gڈD)c5*mp<ܮto034qmOe
KaU5u'rװ|CBPQ<9TIf-	kiN0L0)U"0 010UPrivateLabel1-2970U00U0
	*H
1KG]qSl]y=&b""I'{9$
*8PUl
LGlX1B	li+@]jy.%݊
Z<D&iHΥbb090
vo0
	*H
010	UZA10UWestern Cape10U	Cape Town10
U
Thawte10UCertificate Services1(0&UPersonal Freemail RSA 2000.8.300
030801172929Z
040731172929Z0T10
UEggert1
0U*Lars10ULars Eggert10	*H
	
larse@isi.edu0"0
	*H
0
>ן~H(ԢGV׆־25B03ݰת^RIH=%J
kA^R)yH80P~qrU|c~\;ҋ^哪!֍&d@Cd"O"f$FrGe|r<z"%h+Z`3<}̘}9ʮcnb6RX ٫e~XgK7,ìEYU?V0T0*+e!000L2uMyffBNUbNJJcdZ2s0U0
larse@isi.edu0U00
	*H
5Kkt[@jj:Fg	Xj(8yPo!})5M[	ش]wʼnQd!GyFRiKd!8h\7γSD`a[qiY+Gqn?!090
vo0
	*H
010	UZA10UWestern Cape10U	Cape Town10
U
Thawte10UCertificate Services1(0&UPersonal Freemail RSA 2000.8.300
030801172929Z
040731172929Z0T10
UEggert1
0U*Lars10ULars Eggert10	*H
	
larse@isi.edu0"0
	*H
0
>ן~H(ԢGV׆־25B03ݰת^RIH=%J
kA^R)yH80P~qrU|c~\;ҋ^哪!֍&d@Cd"O"f$FrGe|r<z"%h+Z`3<}̘}9ʮcnb6RX ٫e~XgK7,ìEYU?V0T0*+e!000L2uMyffBNUbNJJcdZ2s0U0
larse@isi.edu0U00
	*H
5Kkt[@jj:Fg	Xj(8yPo!})5M[	ش]wʼnQd!GyFRiKd!8h\7γSD`a[qiY+Gqn?!100010	UZA10UWestern Cape10U	Cape Town10
U
Thawte10UCertificate Services1(0&UPersonal Freemail RSA 2000.8.30
vo0	+0	*H
	1	*H
0	*H
	1
031030213246Z0#	*H
	1VkaV	r0R	*H
	1E0C0
*H
0*H
0
*H
@0+0
*H
(0	+710010	UZA10UWestern Cape10U	Cape Town10
U
Thawte10UCertificate Services1(0&UPersonal Freemail RSA 2000.8.30
vo0*H
	1010	UZA10UWestern Cape10U	Cape Town10
U
Thawte10UCertificate Services1(0&UPersonal Freemail RSA 2000.8.30
vo0
	*H
2ߖTUغB[t^mϮmSmb7_K\tuc҃ߩE$4֝UCB->p{Tje_@I}fH<6c9h{TkzLxJ>ጹYbSe#a#du%E3W~/eN](+v+I$f([~{prz9wޡmzL$̩vx*R>Rzn#E^[!

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FA1837D.4040300>