Date: Sat, 3 Mar 2012 11:37:49 -0700 From: Warner Losh <imp@bsdimp.com> To: Hans Petter Selasky <hselasky@c2i.net> Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@FreeBSD.ORG>, Robert Millan <rmh@FreeBSD.ORG>, freebsd-usb@FreeBSD.ORG, freebsd-arch@FreeBSD.ORG Subject: Re: Exclude USB drivers from main kernel image? Message-ID: <DE8376D4-84EE-4B53-8491-4B2203F08274@bsdimp.com> In-Reply-To: <201203031902.11035.hselasky@c2i.net> References: <CAOfDtXNDXV-hM5t56XKj6-m-Bc=SSZsmB7JnEXsoDGdF2DEuqw@mail.gmail.com> <201202181720.27135.hselasky@c2i.net> <20120303124805.GA4725@thorin> <201203031902.11035.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 3, 2012, at 11:02 AM, Hans Petter Selasky wrote: > On Saturday 03 March 2012 13:48:05 Robert Millan wrote: >> On Sat, Feb 18, 2012 at 05:20:27PM +0100, Hans Petter Selasky wrote: >>> The /etc/devd/usb.conf is regularly updated, though not automatically. It >>> should auto-load most kind of devices. Only additional case that comes to >>> mind is that USB serial console will not be active until devd has >>> executed, if that is enabled. >> >> If early USB serial output is desired, it can be enabled by enabling the >> module in bootloader. Is that an acceptable trade-off? >> >>> Your patch looks OK. Adding ARCH @ >>> >>> Instead of commenting out, I would just remove those lines. >> >> Here's a new patch that removes the lines instead of commenting them out. >> >> Consistently with that, it also removes a few lines which were already >> commented out, using the same criteria. >> >> Also, it disables a few more USB drivers. Due to an oversight my previous >> patch didn't disable all drivers that devd can handle. >> >> Patch is tested with "make universe" on HEAD. > > Hi, > > Your patch looks good. > > Are there any objections committing the patch attached to the previous e-mail? Do all the platforms that had the devices removed work? Have they all been tested? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DE8376D4-84EE-4B53-8491-4B2203F08274>