Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Jan 2018 06:17:45 +0700
From:      Eugene Grosbein <eugen@grosbein.net>
To:        Dimitry Andric <dim@FreeBSD.org>, samm@os2.kiev.ua, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r457814 - in head/sysutils/smartmontools: . files
Message-ID:  <5A4AC199.7070400@grosbein.net>
In-Reply-To: <201801012119.w01LJXE9054540@repo.freebsd.org>
References:  <201801012119.w01LJXE9054540@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
02.01.2018 4:19, Dimitry Andric пишет:
> Author: dim (src committer)
> Date: Mon Jan  1 21:19:33 2018
> New Revision: 457814
> URL: https://svnweb.freebsd.org/changeset/ports/457814
> 
> Log:
>   Make smartmontools 6.6 compile with clang 6.0.0 and higher
>   
>   Because clang 6.0.0 and higher default to -std=gnu++14, like gcc 6 and
>   higher, compiling smartmontools results in the following error:
>   
>   os_freebsd.cpp:487:45: error: invalid suffix on literal; C++11 requires
>   a space between literal and identifier [-Wreserved-user-defined-literal]
>     else if (sscanf(dev, NVME_CTRLR_PREFIX"%d"NVME_NS_PREFIX"%d%c",
>                                               ^
>   
>   Fix this by adding spaces around the NVME_NS_PREFIX macro. This makes
>   the source C++14 compatible.
>   
>   Approved by:	samm@os2.kiev.ua (maintainer)
>   PR:		224826
>   MFH:		2018Q1

Why don't you just modify CFLAGS to set -std=... to right mode
corresponding to current coding style of smartmontools instead?





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5A4AC199.7070400>