Date: Wed, 21 Dec 2011 14:07:49 -0800 From: Adrian Chadd <adrian@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org> Subject: Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211 Message-ID: <CAJ-Vmo=Mcy1pV0=8guqHayNH=mWGv09K1tXdN=09zk702CebBg@mail.gmail.com> In-Reply-To: <201112211700.42772.jhb@freebsd.org> References: <201112211716.pBLHGhDH078507@svn.freebsd.org> <CAJ-Vmont2wOF=TkT1CmZt4Gp0iOc7ZYmfQpjW=8j1=F5DQGNwQ@mail.gmail.com> <201112211700.42772.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 December 2011 14:00, John Baldwin <jhb@freebsd.org> wrote: > I agree it should be reviewed, but if you are seriously depending on > the fact that the shifted values are beyond the edge of the word boundary > and so the result "wraps" to zero, then I'd question the sanity of your code. I agree, but this is all "there be dragons" :) adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=Mcy1pV0=8guqHayNH=mWGv09K1tXdN=09zk702CebBg>