Date: Thu, 31 Aug 2006 06:51:58 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/openbsm - Imported sources Message-ID: <20060831064831.K81771@fledge.watson.org> In-Reply-To: <200608281726.k7SHQdhJ045742@repoman.freebsd.org> References: <200608281726.k7SHQdhJ045742@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 28 Aug 2006, Warner Losh wrote: > imp 2006-08-28 17:26:39 UTC > > FreeBSD src repository > > src/contrib/openbsm - Imported sources > Update of /home/ncvs/src/contrib/openbsm > In directory repoman.freebsd.org:/tmp/cvs-serv45632 > > Log Message: > Import on vendor branch two files that have been tweaked to unbreak > the build. The openbsm folks are free to fix it in any other way they > see fit once they resurface. > > Basically, make everything always be const char **, even though const > char ** usually should be 'const char * const *' in most cases. This > makes the three different definitions consistant and allows world to > build. The audit_record.h file in src/contrib/openbsm/bsm is not used in building FreeBSD; instead, src/sys/bsm is used. If audit_record.h is being used from the contrib tree, there is a problem with the build parts. Looking at the BSD makefiles associated with libbsm, I'm not sure I see how that can happen. Notice that world builds on all platforms but amd64, and that the build failure is not an amd64-specific warning/error in the compile: it has to do with matching prototypes, not with pointer/int size, format strings, etc. I'm not convinced OpenBSM is at fault here, although clearly it's triggered by the OpenBSM import. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060831064831.K81771>