Date: Wed, 11 May 2016 01:37:34 +0000 From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D5872: tcp: Don't prematurely drop receiving-only connections Message-ID: <56eb15d1f3565ca04fbef7c3c9c286e8@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org> References: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--b1_56eb15d1f3565ca04fbef7c3c9c286e8
Content-Type: text/plain; charset = "utf-8"
Content-Transfer-Encoding: 8bit
sepherosa_gmail.com updated this revision to Diff 16171.
sepherosa_gmail.com added a comment.
Change if(..) {panic} into assertion and wrap the assertion using macro.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D5872?vs=15642&id=16171
REVISION DETAIL
https://reviews.freebsd.org/D5872
AFFECTED FILES
sys/netinet/tcp_output.c
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, network, glebius, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, lstewart, hiren, transport, jtl
Cc: gnn, mike-karels.net, jtl
--b1_56eb15d1f3565ca04fbef7c3c9c286e8
Content-Type: text/x-patch; charset=utf-8; name="D5872.16171.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="D5872.16171.patch"
ZGlmZiAtLWdpdCBhL3N5cy9uZXRpbmV0L3RjcF9vdXRwdXQuYyBiL3N5cy9uZXRpbmV0L3RjcF9v
dXRwdXQuYwotLS0gYS9zeXMvbmV0aW5ldC90Y3Bfb3V0cHV0LmMKKysrIGIvc3lzL25ldGluZXQv
dGNwX291dHB1dC5jCkBAIC0xMzAsNiArMTMwLDE2IEBACiAJJlZORVRfTkFNRSh0Y3BfYXV0b3Nu
ZGJ1Zl9tYXgpLCAwLAogCSJNYXggc2l6ZSBvZiBhdXRvbWF0aWMgc2VuZCBidWZmZXIiKTsKIAor
LyoKKyAqIE1ha2Ugc3VyZSB0aGF0IGVpdGhlciByZXRyYW5zbWl0IG9yIHBlcnNpc3QgdGltZXIg
aXMgc2V0IGZvciBTWU4sIEZJTiBhbmQKKyAqIG5vbi1BQ0suCisgKi8KKyNkZWZpbmUgVENQX1hN
SVRfVElNRVJfQVNTRVJUKHRwLCBsZW4sIHRoX2ZsYWdzKQkJCVwKKwlLQVNTRVJUKCgobGVuKSA9
PSAwICYmICgodGhfZmxhZ3MpICYgKFRIX1NZTiB8IFRIX0ZJTikpID09IDApIHx8XAorCSAgICB0
Y3BfdGltZXJfYWN0aXZlKCh0cCksIFRUX1JFWE1UKSB8fAkJCQlcCisJICAgIHRjcF90aW1lcl9h
Y3RpdmUoKHRwKSwgVFRfUEVSU0lTVCksCQkJCVwKKwkgICAgKCJuZWl0aGVyIHJleG10IG5vciBw
ZXJzaXN0IHRpbWVyIGlzIHNldCIpKQorCiBzdGF0aWMgdm9pZCBpbmxpbmUJaGhvb2tfcnVuX3Rj
cF9lc3Rfb3V0KHN0cnVjdCB0Y3BjYiAqdHAsCiAJCQkgICAgc3RydWN0IHRjcGhkciAqdGgsIHN0
cnVjdCB0Y3BvcHQgKnRvLAogCQkJICAgIGxvbmcgbGVuLCBpbnQgdHNvKTsKQEAgLTE1NDUsOSAr
MTU1NSw3IEBACiAJCQl0cC0+dF9zb2Z0ZXJyb3IgPSBlcnJvcjsKIAkJCXJldHVybiAoZXJyb3Ip
OwogCQljYXNlIEVOT0JVRlM6Ci0JICAgICAgICAgICAgICAgIGlmICghdGNwX3RpbWVyX2FjdGl2
ZSh0cCwgVFRfUkVYTVQpICYmCi0JCQkgICAgIXRjcF90aW1lcl9hY3RpdmUodHAsIFRUX1BFUlNJ
U1QpKQotCSAgICAgICAgICAgICAgICAgICAgICAgIHRjcF90aW1lcl9hY3RpdmF0ZSh0cCwgVFRf
UkVYTVQsIHRwLT50X3J4dGN1cik7CisJCQlUQ1BfWE1JVF9USU1FUl9BU1NFUlQodHAsIGxlbiwg
ZmxhZ3MpOwogCQkJdHAtPnNuZF9jd25kID0gdHAtPnRfbWF4c2VnOwogCQkJcmV0dXJuICgwKTsK
IAkJY2FzZSBFTVNHU0laRToKCg==
--b1_56eb15d1f3565ca04fbef7c3c9c286e8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56eb15d1f3565ca04fbef7c3c9c286e8>