Date: Tue, 20 Apr 2021 11:57:06 +0300 From: Dmitry Sivachenko <demon@FreeBSD.org> To: Michael Gmelin <grembo@FreeBSD.org> Cc: Yuri <yuri@freebsd.org>, ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d3ba089a5212 - main - Update to version 2.2.13. Message-ID: <8A878FAE-FEBA-466A-AEC4-DD588028C0EC@FreeBSD.org> In-Reply-To: <0D00C7C3-8460-4CBC-8655-DBF7AB8D97CC@freebsd.org> References: <A14E4A66-FEB3-4E41-B413-8413D479EF89@FreeBSD.org> <0D00C7C3-8460-4CBC-8655-DBF7AB8D97CC@freebsd.org>
index | next in thread | previous in thread | raw e-mail
> On 20 Apr 2021, at 02:07, Michael Gmelin <grembo@FreeBSD.org> wrote: > > > >> On 20. Apr 2021, at 00:24, Dmitry Sivachenko <demon@freebsd.org> wrote: >> >> >> >>> On 20 Apr 2021, at 01:17, Yuri <yuri@FreeBSD.org> wrote: >>> >>> On 4/19/21 3:13 PM, Dmitry Sivachenko wrote: >>>> Update to version 2.2.13. >>> >>> >>> Why didn't you mention in the commit message what port was updated? >>> net/haproxy is one of thousands of ports and having a message like this doesn't help to understand what the change is. >>> >> >> Hello, >> >> what do you mean 'what port was updated'? It is clean from the commit log that it is net/haproxy that was updated, only two files changed: >> Update to version 2.2.13. >> --- >> net/haproxy/Makefile | 2 +- >> net/haproxy/distinfo | 6 +++--- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> >> Or may be I am missing something... > > The idea is to prefix the first line of the commit with <category>/<name>:, so it’s easier to understand which port was changed when looking at a list of commits. > > See here for an example of why this helps: > https://cgit.freebsd.org/ports/log/ > Aha, I see now. I used to think that commit log should describe what has changed, and commit logs are just tool. But things changed and now we should think how commit log will look in mail client provided you read only subject line :)home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8A878FAE-FEBA-466A-AEC4-DD588028C0EC>