Date: Fri, 11 Jun 2010 11:16:24 +0930 From: "Daniel O'Connor" <doconnor@gsoft.com.au> To: Rui Paulo <rpaulo@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r209011 - stable/8/sys/dev/ath/ath_hal/ar5211 Message-ID: <3BE36947-BCB4-4A6D-9040-873CFD144F3B@gsoft.com.au> In-Reply-To: <201006102034.o5AKYMXX058081@svn.freebsd.org> References: <201006102034.o5AKYMXX058081@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/06/2010, at 6:04, Rui Paulo wrote:
> Log:
> MFC r208644:
> Due to the way HALDEBUG() is defined, we need to add curly brackets
> when using it as a sole if clause instruction.
> While there, fix 'const static' typo.
Why not fix HALDEBUG? ie wrap it in do { } while (0)
Although that said when I looked at HALDEBUG on 8.0 it was defined as a =
function so it is a non issue there.
HAL_DEBUG is different but I can't actually find where that is defined.
--
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
"The nice thing about standards is that there
are so many of them to choose from."
-- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3BE36947-BCB4-4A6D-9040-873CFD144F3B>